Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-134215: PyREPL: Do not show underscored modules by default during autocompletion#134267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 26 commits intopython:mainfromkevteg:pyrepl_underscored_fix
May 20, 2025

Conversation

kevteg
Copy link
Contributor

@kevtegkevteg commentedMay 19, 2025•
edited
Loading

  • Add_is_suggestion_match method to the ModuleCompleter module
  • Add new tests to check autocomplete behaviour with private and public methods

joaopedroalbq and Gerson4G reacted with hooray emoji
* Add _should_add_module_name method to the ModuleCompleter module* Add new tests to check autocomplete behaviour on private method
@python-cla-bot
Copy link

python-cla-botbot commentedMay 19, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

kevteg reacted with eyes emoji

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@kevteg
Copy link
ContributorAuthor

@tomasr8 ready for your review!

kevtegand others added2 commitsMay 19, 2025 17:53
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@tomasr8tomasr8 changed the titlegh-134215: Improve ModuleCompleter modulegh-134215: PyREPL: Do not show underscored modules by default during autocompletionMay 20, 2025
@ambvambv added the needs backport to 3.14bugs and security fixes labelMay 20, 2025
@ambvambv merged commita3a3cf6 intopython:mainMay 20, 2025
47 checks passed
@miss-islington-app
Copy link

Thanks@kevteg for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2025
…uring autocompletion (pythongh-134267)(cherry picked from commita3a3cf6)Co-authored-by: Kevin Hernández <kevin.hernandez@unet.edu.ve>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Tomas R. <tomas.roun8@gmail.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

GH-134388 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 20, 2025
@tomasr8
Copy link
Member

Congrats@kevteg !!

kevteg reacted with heart emoji

ambv added a commit that referenced this pull requestMay 20, 2025
…during autocompletion (gh-134267) (gh-134388)(cherry picked from commita3a3cf6)Co-authored-by: Kevin Hernández <kevin.hernandez@unet.edu.ve>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Tomas R. <tomas.roun8@gmail.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tomasr8tomasr8tomasr8 approved these changes

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@ambvambvambv approved these changes

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@kevteg@tomasr8@ambv@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp