Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-134261: ZipFile - Don't rely on local time for reproducible builds & tests#134264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
python-cla-botbot commentedMay 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
I added this feature 8 months ago. There was a reason for using localtime. See#124435 (review) and54a7116 Maybe we can ask@jaraco |
Uh oh!
There was an error while loading.Please reload this page.
See#134261 for issue background and technical detail on causes. This solves the issue by using
gmtime
wheneverSOURCE_DATE_EPOCH
is involved, to prevent pulling in system timezone information when performing time calculations.