Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-134262: Add retries to generate_sbom.py#134263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 6 commits intopython:mainfromemmatyping:retry-generate-sbom-dl
May 21, 2025

Conversation

emmatyping
Copy link
Member

@emmatypingemmatyping commentedMay 19, 2025•
edited by bedevere-appbot
Loading

Tools/build/generate_sbom.py downloads artifacts, which can flake. This commit adds simple exponential back-off retries to the download to avoid failures due to network flakes.

generate_sbom.py downloads artifacts, which canflake. This commit adds exponential backoff to thedownload to avoid failures due to network flakes.
Copy link
Contributor

@sethmlarsonsethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thank you!

emmatypingand others added2 commitsMay 19, 2025 12:45
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
- Add `base_delay` for retries- use a for loop instead of while loop- rename retries to max_retries
@hugovkhugovk merged commit0c5a8b0 intopython:mainMay 21, 2025
46 checks passed
@hugovk
Copy link
Member

Thanks! And backport to 3.13?

@emmatyping
Copy link
MemberAuthor

Yeah backport to 3.14 and 3.13 is probably a good idea.

@hugovk
Copy link
Member

Would you like to add the "needs backport" labels?

@emmatypingemmatyping added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 21, 2025
@miss-islington-app
Copy link

Thanks@emmatyping for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@emmatyping for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 21, 2025
(cherry picked from commit0c5a8b0)Co-authored-by: Emma Smith <emma@emmatyping.dev>Co-authored-by: Semyon Moroz <donbarbos@proton.me>
@miss-islington-app
Copy link

Sorry,@emmatyping and@hugovk, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 0c5a8b0b55238a45b9073d06a10c3a59568cdf3c 3.13

@bedevere-app
Copy link

GH-134460 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 21, 2025
@hugovk
Copy link
Member

hugovk commentedMay 21, 2025•
edited
Loading

Here's a build that failed even withdownload_with_retries:

https://github.com/python/cpython/actions/runs/15169080044/job/42654367027?pr=134456

Shall we bump some numbers? And print outdownload_with_retries and the current retry/delay?

Would help us identify any flaky resources and possibly fetch from a reliable location.

emmatyping reacted with thumbs up emoji

@emmatyping
Copy link
MemberAuthor

Yeah, I can bump numbers (wanted to be conservative initially), note the location, and maybe add jitter?

@hugovk
Copy link
Member

Thanks, not sure how much jitter would help here, but no objection.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jeanmarinho529jeanmarinho529jeanmarinho529 left review comments

@sethmlarsonsethmlarsonsethmlarson approved these changes

@donBarbosdonBarbosdonBarbos approved these changes

Assignees

@hugovkhugovk

Labels
needs backport to 3.13bugs and security fixesskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@emmatyping@hugovk@sethmlarson@donBarbos@jeanmarinho529
[8]ページ先頭
©2009-2025 Movatter.jp