Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.14] gh-128639: Don't assume one thread in subinterpreter finalization (gh-128640)#134254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
miss-islington wants to merge1 commit intopython:3.14
base:3.14
Choose a base branch
Loading
frommiss-islington:backport-9859791-3.14

Conversation

miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commentedMay 19, 2025
edited by bedevere-appbot
Loading

Incidentally, this also fixed the warning not showing up if a subinterpreter wasn't
cleaned up via _interpreters.destroy. I had to update some of the tests as a result.
(cherry picked from commit9859791)

Co-authored-by: Peter Biermazintensitydev@gmail.com

…on (pythongh-128640)Incidentally, this also fixed the warning not showing up if a subinterpreter wasn'tcleaned up via _interpreters.destroy. I had to update some of the tests as a result.(cherry picked from commit9859791)Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@hugovk
Copy link
Member

Let's check the buildbot failure before merging this:#128640 (comment)

ericsnowcurrently reacted with thumbs up emoji

@ZeroIntensity
Copy link
Member

That failure looks related, but I have absolutely no idea how.

@vstinner
Copy link
Member

I suppose that this change should not be merged, since you proposed a revert for the same change in the main branch:#134256

@ZeroIntensity
Copy link
Member

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@ZeroIntensity for commit76bcc46 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134254%2Fmerge

The command will test the builders whose names match following regular expression:iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@ZeroIntensity
Copy link
Member

I'm going to run the buildbots to see if the crash is somehow related to something else on 3.15. I'm still pretty lost on what could be the cause. I can only see two possibilities:

  • We revealed an existing bug with_PyThreadState_DeleteList and/or_PyThreadState_RemoveExcept.
  • The embedding test revealed a bug with the implementation, but I'm not sure what. Maybe I broke destroying interpreters with only one thread state?

@mhsmith
Copy link
Member

I'm not sure if it's related, but the iOS buildbot has also been experiencing another intermittent subinterpreters failure:#127108. The most recent instance was in#125962 (comment).

@ZeroIntensity
Copy link
Member

In this specific case, the change was related. It's reverted on main. I haven't had time to look into those other failures yet.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@miss-islington@hugovk@ZeroIntensity@vstinner@bedevere-bot@mhsmith

[8]ページ先頭

©2009-2025 Movatter.jp