Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
[3.14] gh-128639: Don't assume one thread in subinterpreter finalization (gh-128640)#134254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:3.14
Are you sure you want to change the base?
Conversation
…on (pythongh-128640)Incidentally, this also fixed the warning not showing up if a subinterpreter wasn'tcleaned up via _interpreters.destroy. I had to update some of the tests as a result.(cherry picked from commit9859791)Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Let's check the buildbot failure before merging this:#128640 (comment) |
That failure looks related, but I have absolutely no idea how. |
I suppose that this change should not be merged, since you proposed a revert for the same change in the main branch:#134256 |
!buildbot iOS |
bedevere-bot commentedMay 21, 2025
🤖 New build scheduled with the buildbot fleet by@ZeroIntensity for commit76bcc46 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134254%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
I'm going to run the buildbots to see if the crash is somehow related to something else on 3.15. I'm still pretty lost on what could be the cause. I can only see two possibilities:
|
I'm not sure if it's related, but the iOS buildbot has also been experiencing another intermittent subinterpreters failure:#127108. The most recent instance was in#125962 (comment). |
In this specific case, the change was related. It's reverted on main. I haven't had time to look into those other failures yet. |
Uh oh!
There was an error while loading.Please reload this page.
Incidentally, this also fixed the warning not showing up if a subinterpreter wasn't
cleaned up via _interpreters.destroy. I had to update some of the tests as a result.
(cherry picked from commit9859791)
Co-authored-by: Peter Biermazintensitydev@gmail.com