Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-80184: Set getattr(socket, "SOMAXCONN", 5) as the default queue size for TCPServer#134249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

sahilds1
Copy link
Contributor

@sahilds1sahilds1 commentedMay 19, 2025
edited by bedevere-appbot
Loading

@python-cla-bot
Copy link

python-cla-botbot commentedMay 19, 2025
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@picnixz
Copy link
Member

Thanks for the PR, but we should add a NEWS entry as well as a.. versionchanged:: next in the rst docs of TCPServer.

sahilds1 reacted with thumbs up emoji

@picnixzpicnixz changed the titlegh-80184: Set 0 as the default queue size for TCPServegh-80184: Set 0 as the default queue size for TCPServerMay 19, 2025
@gpshead
Copy link
Member

Okay, i this change looks right for what was described in the issue. BUT i've done a little more research to double check the implications. we may not want to use0 even though that felt right. apparently some platforms treat that as actual 0, effectively disabling connections. posix doesn't seem torequire 0 to mean "default". ugh.

In particular Linux -https://bugzilla.kernel.org/show_bug.cgi?id=119141

a better alternative effectively similar to what the intent of 0 was is probably something like:

getattr(socket, "SOMAXCONN", 5) to use socket.SOMAXCONN if defined otherwise our old non-zero default.

sahilds1 reacted with thumbs up emoji

@sahilds1sahilds1 changed the titlegh-80184: Set 0 as the default queue size for TCPServergh-80184: Set getattr(socket, "SOMAXCONN", 5) as the default queue size for TCPServerMay 19, 2025
@github-project-automationgithub-project-automationbot moved this fromTodo toIn Progress inSprint 2024May 19, 2025
@gpsheadgpshead added the needs backport to 3.14bugs and security fixes labelMay 19, 2025
@gpsheadgpshead removed the needs backport to 3.14bugs and security fixes labelMay 19, 2025
@gpsheadgpsheadenabled auto-merge (squash)May 19, 2025 19:04
@gpsheadgpshead merged commit92f85ff intopython:mainMay 19, 2025
47 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inSprint 2024May 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gpsheadgpsheadgpshead approved these changes

Assignees
No one assigned
Labels
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@sahilds1@picnixz@gpshead

[8]ページ先頭

©2009-2025 Movatter.jp