NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

GH-130415: Use`POP_TWO_LOAD_CONST_INLINE_BORROW`#134241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

savannahostrowski wants to merge5 commits intopython:main

base:main

Choose a base branch

fromsavannahostrowski:use_pop_2

Open

GH-130415: Use`POP_TWO_LOAD_CONST_INLINE_BORROW`#134241

savannahostrowski wants to merge5 commits intopython:mainfromsavannahostrowski:use_pop_2

+118 −10

Conversation

Copy link

Member

savannahostrowski commentedMay 19, 2025•
edited by bedevere-appbot
Loading

Issue:Better constant narrowing in the JIT optimizer #130415

savannahostrowski added2 commits

May 19, 2025 11:22

Use POP_TWO_LOAD_CONST_INLINE_BORROW

6614ae6

Add newline back

37ccb18

savannahostrowski requested a review fromFidget-Spinner as acode owner

May 19, 2025 15:24

bedevere-appbot mentioned this pull request

May 19, 2025

Better constant narrowing in the JIT optimizer#130415

Open

17 tasks

bedevere-appbot added the awaiting core review label

May 19, 2025

blurb-itbotand others added3 commits

May 19, 2025 15:26

📜🤖 Added by blurb_it.

3c19e43

Fix rhs and lhs

6c7861c

Merge branch 'use_pop_2' ofhttps://github.com/savannahostrowski/cpython

1673250

 into use_pop_2

Copy link

Member

Fidget-Spinner commentedMay 19, 2025

Thanks for the PR. I'd like to advocate for this PR#132733 which will simplify this PR quite a bit. All you'd have to do after that PR lands is to addpure to the current bytecode definition. Then if you want you can improve the cases generator to automatically insert the pops.