Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-131357: Add tests for zero-sized bytes objects in test_bytes.py#134234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 9 commits intopython:mainfromabstractedfox:main
May 20, 2025

Conversation

abstractedfox
Copy link
Contributor

@abstractedfoxabstractedfox commentedMay 19, 2025•
edited by bedevere-appbot
Loading

Concerns issue#131357 and adds slightly more descriptive comments for a few functions that crash when passed null

@python-cla-bot
Copy link

python-cla-botbot commentedMay 19, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-appbedevere-appbot added the testsTests in the Lib/test dir labelMay 19, 2025
@bedevere-app

This comment was marked as resolved.

@bedevere-app

This comment was marked as resolved.

Copy link
Contributor

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You need to sign the CLA.


# CRASHES check(NULL)
# CRASHES check(NULL) #PyBytes_CheckExact() expects PyObject*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

How are these comments related? They should probably be on two lines.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Apologies; that was meant to explain why it crashes (it felt a little vague whether or not it was expected behavior). Would it be better on the next line, or in parenthesis or similar?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

explain why it crashes

Then it should be on the same line, but without the#, as that makes it seem like 2 different notes.

@bedevere-app

This comment was marked as resolved.

@StanFromIreland
Copy link
Contributor

Please do not click the "Update" button for no reason, see thedevguide.

@abstractedfox
Copy link
ContributorAuthor

Please do not click the "Update" button for no reason, see thedevguide.

Oh, I apologize

@vstinner
Copy link
Member

I clicked on [Update branch] to try to repair the CI.

@vstinner
Copy link
Member

Many CI fail with "cancelled", I don't know why :-(

@CAM-Gerlach
Copy link
Member

@vstinner Myself and@webknjaz figured it out, its a longstanding issue with the concurrency group specifier in our workflow not sufficiently disambiguating PRs when multiple contributors submit a PR with the same branch name, in this casemain.@abstractedfox will have a PR we assisted them on to fix this that should unblock this one.

vstinner reacted with thumbs up emoji

@vstinner
Copy link
Member

Close/reopen the PR to try to repair the CI.

@vstinner
Copy link
Member

@vstinner Myself and@webknjaz figured it out, its a longstanding issue with the concurrency group specifier in our workflow not sufficiently disambiguating PRs when multiple contributors submit a PR with the same branch name, in this case main.@abstractedfox will have a PR we assisted them on to fix this that should unblock this one.

I suppose that it's this PR:#134310.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@vstinnervstinnerenabled auto-merge (squash)May 20, 2025 12:00
@vstinnervstinner merged commit306f9e0 intopython:mainMay 20, 2025
67 of 76 checks passed
@picnixz
Copy link
Member

@vstinner We backported the tests for bytesarray, do you want to backport those tests as well?

@vstinnervstinner added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 20, 2025
@miss-islington-app
Copy link

Thanks@abstractedfox for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@abstractedfox for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2025
….py (pythonGH-134234)(cherry picked from commit306f9e0)Co-authored-by: abstractedfox <coldcaption@gmail.com>Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2025
….py (pythonGH-134234)(cherry picked from commit306f9e0)Co-authored-by: abstractedfox <coldcaption@gmail.com>Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

GH-134378 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 20, 2025
@bedevere-app
Copy link

GH-134379 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 20, 2025
@vstinner
Copy link
Member

@vstinner We backported the tests for bytesarray, do you want to backport those tests as well?

Sure. Let me backport these changes to 3.13 and 3.14 branches.

vstinner added a commit that referenced this pull requestMay 20, 2025
…s.py (GH-134234) (#134379)gh-131357: Add tests for zero-sized bytes objects in test_bytes.py (GH-134234)(cherry picked from commit306f9e0)Co-authored-by: abstractedfox <coldcaption@gmail.com>Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull requestMay 20, 2025
…s.py (GH-134234) (#134378)gh-131357: Add tests for zero-sized bytes objects in test_bytes.py (GH-134234)(cherry picked from commit306f9e0)Co-authored-by: abstractedfox <coldcaption@gmail.com>Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@vstinnervstinnervstinner approved these changes

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@abstractedfox@StanFromIreland@vstinner@CAM-Gerlach@picnixz@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp