Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-131178: fix SSL tests forhttp.server command-line interface#134224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ggqlq wants to merge89 commits intopython:mainfromggqlq:main

Conversation

ggqlq
Copy link
Contributor

@ggqlqggqlq commentedMay 19, 2025
edited by bedevere-appbot
Loading

ggqlqand others added30 commitsApril 15, 2025 02:38
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz
Copy link
Member

!buildbot ASAN

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@picnixz for commit0e0fb7a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134224%2Fmerge

The command will test the builders whose names match following regular expression:ASAN

The builders matched are:

  • AMD64 Arch Linux Asan PR
  • AMD64 Arch Linux Asan Debug PR
  • x86-64 MacOS Intel ASAN NoGIL PR

@picnixz
Copy link
Member

!buildbot x86-64 MacOS Intel ASAN NoGIL PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@picnixz for commite818bb6 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134224%2Fmerge

The command will test the builders whose names match following regular expression:x86-64 MacOS Intel ASAN NoGIL PR

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR

@picnixz
Copy link
Member

picnixz commentedMay 19, 2025
edited
Loading

So the failures are the following:

======================================================================ERROR: test_http_client (test.test_httpservers.CommandLineRunTimeTestCase.test_http_client)----------------------------------------------------------------------Traceback (most recent call last):  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.macos-with-brew.asan.nogil/build/Lib/test/test_httpservers.py", line 1520, in test_http_client    res = self.fetch_file(f'http://{bind}:{port}/{self.served_file_name}')  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.macos-with-brew.asan.nogil/build/Lib/test/test_httpservers.py", line 1476, in fetch_file    context = ssl.create_default_context()              ^^^^^^^^^^^^^^^^^^^^^^^^^^AttributeError: 'NoneType' object has no attribute 'create_default_context'======================================================================FAIL: test_https_client (test.test_httpservers.CommandLineRunTimeTestCase.test_https_client)----------------------------------------------------------------------Traceback (most recent call last):  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.macos-with-brew.asan.nogil/build/Lib/test/test_httpservers.py", line 1533, in test_https_client    self.assertTrue(self.wait_for_server(proc, 'https', port, bind))    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: False is not true----------------------------------------------------------------------

We fixed the AttributeError, but I don't know why the other happens.

@picnixz
Copy link
Member

Note: using localhost instead of 127.0.0.1 doesn't seem the right solution as we also have tests with 127.0.0.1 elsewhere.

However, maybe we can just ignore the bind itself and check for the "best" address (which is chosen byhttp.server via_get_best_family).

@picnixz
Copy link
Member

I've committed directly to your branch as the tier-1 bot is failing (making it hard to fix another issue I introduced in a subsequent commit, not your fault!)

@picnixz
Copy link
Member

!buildbot x86-64 MacOS Intel ASAN NoGIL PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@picnixz for commit9192281 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134224%2Fmerge

The command will test the builders whose names match following regular expression:x86-64 MacOS Intel ASAN NoGIL PR

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR

@picnixz

This comment was marked as resolved.

@picnixz
Copy link
Member

Ok, so the tests now hang on non-Linux bots. I'll stop working on this branch and will come back on my linux in a few hours.

Copy link
Member

@picnixzpicnixz left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

So localhost doesn't work and 127.0.0.1 doesn't work for some build bots. I think we'll just leave it to the script the responsibility to start the server and we'll deduce the bind address from the output.

@picnixz
Copy link
Member

Ok, so now, the tests entirely hang for some obscure reasons. I'll open a new PR instead, sorry for messing up your branch though (but thank you for your quick response time).

@picnixz
Copy link
Member

I've opened#134279

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz approved these changes

Assignees
No one assigned
Labels
awaiting mergeskip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ggqlq@picnixz@bedevere-bot@ZeroIntensity

[8]ページ先頭

©2009-2025 Movatter.jp