Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-133319: Use python versioning inmsgfmt &pygettext#134205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
StanFromIreland wants to merge3 commits intopython:main
base:main
Choose a base branch
Loading
fromStanFromIreland:pyver-get-msg

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIrelandStanFromIreland commentedMay 19, 2025
edited by bedevere-appbot
Loading

Simplest approach maintaining full backwards compatibility. We cannot use the version of the python running the script, updating this number every few years is not overly complex, it can be picked up by any pr modifying the file.

Wulian233 reacted with thumbs up emoji
@StanFromIreland
Copy link
ContributorAuthor

Request:@tomasr8 ,@serhiy-storchaka

@encukou
Copy link
Member

This would put the burden of updating the numbers on the release manager, who bumps the CPython version. I doubt they'll want that.

Can you find a way to do this with less maintenance overhead?

@StanFromIreland
Copy link
ContributorAuthor

StanFromIreland commentedMay 28, 2025
edited
Loading

IMO it shouldn’t fall on the release manager, since the file won’t have changed anyway. In my mind I think it should just be done as part of whatever pr that modifies the script in a given version.

Using the version of the python running it will be misleading.

@encukou
Copy link
Member

Ah. Could you document that expectation; perhaps put the command to do it in a comment?

@StanFromIreland
Copy link
ContributorAuthor

perhaps put the command to do it in a comment?

I can do that.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@StanFromIreland@encukou

[8]ページ先頭

©2009-2025 Movatter.jp