Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-133319: Use python versioning inmsgfmt
&pygettext
#134205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Request:@tomasr8 ,@serhiy-storchaka |
This would put the burden of updating the numbers on the release manager, who bumps the CPython version. I doubt they'll want that. Can you find a way to do this with less maintenance overhead? |
StanFromIreland commentedMay 28, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
IMO it shouldn’t fall on the release manager, since the file won’t have changed anyway. In my mind I think it should just be done as part of whatever pr that modifies the script in a given version. Using the version of the python running it will be misleading. |
Ah. Could you document that expectation; perhaps put the command to do it in a comment? |
I can do that. |
Uh oh!
There was an error while loading.Please reload this page.
Simplest approach maintaining full backwards compatibility. We cannot use the version of the python running the script, updating this number every few years is not overly complex, it can be picked up by any pr modifying the file.
msgfmt.py
/pygettext.py
#133319