Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task#134202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

graingert
Copy link
Contributor

@graingertgraingert commentedMay 19, 2025•
edited by github-actionsbot
Loading

@graingertgraingert marked this pull request as ready for reviewMay 20, 2025 06:54
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM except I'm uneasy with how name, context and eager_task arguments are presented.

@gvanrossum
Copy link
Member

You're also going to backport these to 3.13 right? (But describing how 3.13.4 works -- you can't change 3.13.3 by definition).

@graingert
Copy link
ContributorAuthor

graingert commentedMay 20, 2025•
edited
Loading

You're also going to backport these to 3.13 right? (But describing how 3.13.4 works -- you can't change 3.13.3 by definition).

I thought we were happy with the docs on 3.13 now? So this won't need a backport

@gvanrossum
Copy link
Member

I thought we were happy with the docs on 3.13 now? So this won't need a backport

Agreed, not to 3.13. But this should be marked as backport to 3.14 right?

What do you think about my comment on the signature description?

@gvanrossumgvanrossum added the needs backport to 3.14bugs and security fixes labelMay 20, 2025
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LG then! I will merge and ensure a backport to 3.14 happens.

@gvanrossumgvanrossum changed the titlegh-128307: update docs to TaskGroup.create_task and asyncio.create_taskgh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_taskMay 22, 2025
@gvanrossumgvanrossum merged commita3d0306 intopython:mainMay 22, 2025
32 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsMay 22, 2025
@miss-islington-app
Copy link

Thanks@graingert for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 22, 2025
…e_task, asyncio.create_task (pythonGH-134202)(cherry picked from commita3d0306)Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@bedevere-app
Copy link

GH-134553 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 22, 2025
kumaraditya303 pushed a commit that referenced this pull requestMay 23, 2025
…te_task, asyncio.create_task (GH-134202) (#134553)gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task (GH-134202)(cherry picked from commita3d0306)Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@graingert@gvanrossum@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp