Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-134155: fix AttributeError in email._header_value_parser.get_address#134194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sergey-miryanov wants to merge11 commits intopython:main
base:main
Choose a base branch
Loading
fromsergey-miryanov:gh-134152-fix-unbound-local-error-in-email

Conversation

sergey-miryanov
Copy link
Contributor

@sergey-miryanovsergey-miryanov commentedMay 18, 2025•
edited by bedevere-appbot
Loading

There are two errors:

  1. The first one from original issue for UnboundLocalError
  2. The second one I observed when tried write a test forparse_message_id - I found that in some cases error placed to the list of tokens not of defects.

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

cc@bitdancer

The defects fix seems right

@picnixzpicnixz changed the titlegh-134152: fix unbound local error while parsing message_id in emailgh-134152: fixUnboundLocalError while parsingmessage_id in emailMay 18, 2025
…0HwbX.rstCo-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bitdancer
Copy link
Member

Drat. I somehow missed your PR before I submitted mine (#134233). We should combine the two. You want to pull in the extra tests from mine? Thanks for catching the defect issue.

I think my early return is clearer than setting pos=0 even though they have the same effect.

@sergey-miryanov
Copy link
ContributorAuthor

Yeah, your solution with early return looks better than mine.

I'm happy to revert my changes withpos=0 and keep only defects fix. After this we can keep two PRs or merge one with other. This is up to you because I'm very new here.

@sergey-miryanov
Copy link
ContributorAuthor

Tests should pass after#134233 will be merged.

@bitdancer
Copy link
Member

Sure, that works for me.

@sergey-miryanov
Copy link
ContributorAuthor

@bitdancer I'm sorry to bother you. Perhaps I misunderstood you. Do you expect me to merge your PR with this one?

@bitdancer
Copy link
Member

No, I just haven't gotten around to merging mine yet. I'll do it soon ;)

@sergey-miryanov
Copy link
ContributorAuthor

Thanks! I wasn't sure that I got you right, so I thought I'd clarify.

@hugovk
Copy link
Member

(Updating frommain after the merge of#134233.)

@bitdancerbitdancer changed the titlegh-134152: fixUnboundLocalError while parsingmessage_id in emailgh-134155: fixUnboundLocalError while parsingmessage_id in emailMay 26, 2025
@bitdancerbitdancer changed the titlegh-134155: fixUnboundLocalError while parsingmessage_id in emailgh-134155: fix AttributeError in email._header_value_parser.get_addressMay 26, 2025
@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sergey-miryanov
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-app
Copy link

Thanks for making the requested changes!

@bitdancer: please review the changes made to this pull request.

@bedevere-appbedevere-appbot requested a review frombitdancerMay 26, 2025 19:23
Copy link
Member

@bitdancerbitdancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks like it was a stupid mistake on my part :)

PR looks good just one tweak.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sergey-miryanov
Copy link
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-app
Copy link

Thanks for making the requested changes!

@bitdancer: please review the changes made to this pull request.

@bedevere-appbedevere-appbot requested a review frombitdancerMay 27, 2025 05:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz left review comments

@bitdancerbitdancerAwaiting requested review from bitdancer

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@sergey-miryanov@bitdancer@hugovk@picnixz
[8]ページ先頭
©2009-2025 Movatter.jp