Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-130478: Fixed HACL compilation failure on macOS Silicon#134188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
naizhao wants to merge6 commits intopython:main
base:main
Choose a base branch
Loading
fromServBay:main
Open
Show file tree
Hide file tree
Changes from1 commit
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Fix: Address feedback on HACL* universal2 configure checks
  • Loading branch information
@naizhao
naizhao committedMay 19, 2025
commitc11f3488377e971dd0f5e08c30b8ec31f0d0582c
11 changes: 9 additions & 2 deletionsconfigure
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

11 changes: 9 additions & 2 deletionsconfigure.ac
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7920,6 +7920,13 @@ AC_SUBST([LIBHACL_CFLAGS])
LIBHACL_LDFLAGS= # for now, no specific linker flags are needed
AC_SUBST([LIBHACL_LDFLAGS])

# Determine if the specific HACL* universal2 implementation should be used
use_hacl_universal2_impl=no
if test "$UNIVERSAL_ARCHS" = "universal2" -o \
\( "$build_cpu" = "aarch64" -a "$build_vendor" = "apple" \); then
use_hacl_universal2_impl=yes
fi

# The SIMD files use aligned_alloc, which is not available on older versions of
# Android.
# The *mmintrin.h headers are x86-family-specific, so can't be used on WASI.
Expand All@@ -7936,7 +7943,7 @@ then
# available on x86_64. However, performance of the HACL SIMD128 implementation
# isn't great, so it's disabled on ARM64.
AC_MSG_CHECKING([for HACL* SIMD128 implementation])
if test "$UNIVERSAL_ARCHS" = "universal2" -o \( "$build_cpu" = "aarch64" -a "$build_vendor" = "apple" \); then
if test "$use_hacl_universal2_impl" = "yes"; then
[LIBHACL_BLAKE2_SIMD128_OBJS="Modules/_hacl/Hacl_Hash_Blake2s_Simd128_universal2.o"]
AC_MSG_RESULT([universal2])
else
Expand DownExpand Up@@ -7968,7 +7975,7 @@ then
# implementation requires symbols that aren't available on ARM64. Use a
# wrapped implementation if we're building for universal2.
AC_MSG_CHECKING([for HACL* SIMD256 implementation])
if test "$UNIVERSAL_ARCHS" = "universal2" -o \( "$build_cpu" = "aarch64" -a "$build_vendor" = "apple" \); then
if test "$use_hacl_universal2_impl" = "yes"; then
[LIBHACL_BLAKE2_SIMD256_OBJS="Modules/_hacl/Hacl_Hash_Blake2b_Simd256_universal2.o"]
AC_MSG_RESULT([universal2])
else
Expand Down
Loading
[8]ページ先頭
©2009-2025 Movatter.jp