Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-130478: Fixed HACL compilation failure on macOS Silicon#134188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Uh oh!
There was an error while loading.Please reload this page.
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
bedevere-bot commentedMay 19, 2025
🤖 New build scheduled with the buildbot fleet by@picnixz for commitb05d183 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134188%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
picnixz commentedMay 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Don't forget to update the configure script (my bad, the build bots will need to be run twice because of your next commit) |
configure updated |
bedevere-bot commentedMay 19, 2025
🤖 New build scheduled with the buildbot fleet by@picnixz for commite89919d 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134188%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
picnixz commentedMay 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Until the build bots are done, please doNOT commit anything to this branch (in particular, don't hit the "Update branch" button) |
Fix: Prevent HACL compilation failure on macOS Silicon when not building universal binaries (#130478)
Problem:
In Python 3.14.0b1, compiling on macOS Silicon without the
--enable-universalsdk
flag resulted in a compilation error: "unknown type name 'Lib_IntVector_Intrinsics_vec256'". This occurred because the previous fix for a similar issue (#123748,#130366,#129043) in theconfigure
andconfigure.ac
scripts relied on the$UNIVERSAL_ARCHS
variable for conditional checks. However,$UNIVERSAL_ARCHS
is only set to "universal2" when--enable-universalsdk
is explicitly provided. When this flag is absent (as is the case when only targeting the native arm64 architecture),$UNIVERSAL_ARCHS
defaults to "32-bit", causing the conditional logic to fail and the necessary definitions for HACL not to be included.Solution:
This PR modifies the
configure
andconfigure.ac
scripts to use the$build_cpu
and$build_vendor
variables instead of$UNIVERSAL_ARCHS
for determining the target architecture. This approach ensures that the necessary HACL definitions are included when building on macOS with an arm64 architecture, even when--enable-universalsdk
is not specified.The PR provides a quick fix based on
$build_cpu
and$build_vendor
. While functional, this PR aims for a more robust and maintainable solution by directly checking for the "aarch64" architecture in$build_cpu
.Testing:
This fix has been tested successfully on macOS Silicon (arm64) when building Python 3.14.0b1 without the
--enable-universalsdk
flag. The compilation now completes without the "unknown type name 'Lib_IntVector_Intrinsics_vec256'" error.