Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-130478: Fixed HACL compilation failure on macOS Silicon#134177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
naizhao wants to merge0 commits intopython:mainfromServBay:main

Conversation

naizhao
Copy link

@naizhaonaizhao commentedMay 18, 2025
edited by bedevere-appbot
Loading

Fix: Prevent HACL compilation failure on macOS Silicon when not building universal binaries (#130478)

Problem:

In Python 3.14.0b1, compiling on macOS Silicon without the--enable-universalsdk flag resulted in a compilation error: "unknown type name 'Lib_IntVector_Intrinsics_vec256'". This occurred because the previous fix for a similar issue (#123748,#130366,#129043) in theconfigure andconfigure.ac scripts relied on the$UNIVERSAL_ARCHS variable for conditional checks. However,$UNIVERSAL_ARCHS is only set to "universal2" when--enable-universalsdk is explicitly provided. When this flag is absent (as is the case when only targeting the native arm64 architecture),$UNIVERSAL_ARCHS defaults to "32-bit", causing the conditional logic to fail and the necessary definitions for HACL not to be included.

Solution:

This PR modifies theconfigure andconfigure.ac scripts to use the$build_cpu and$build_vendor variables instead of$UNIVERSAL_ARCHS for determining the target architecture. This approach ensures that the necessary HACL definitions are included when building on macOS with an arm64 architecture, even when--enable-universalsdk is not specified.

The PR provides a quick fix based on$build_cpu and$build_vendor. While functional, this PR aims for a more robust and maintainable solution by directly checking for the "aarch64" architecture in$build_cpu.

Testing:

This fix has been tested successfully on macOS Silicon (arm64) when building Python 3.14.0b1 without the--enable-universalsdk flag. The compilation now completes without the "unknown type name 'Lib_IntVector_Intrinsics_vec256'" error.

Related Issue:

@python-cla-bot
Copy link

python-cla-botbot commentedMay 18, 2025
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@naizhaonaizhao changed the titleFixed: HACL compilation failure on macOS SiliconGH-130478: Fixed HACL compilation failure on macOS SiliconMay 18, 2025
configure.ac Outdated
@@ -7936,7 +7936,7 @@ then
# available on x86_64. However, performance of the HACL SIMD128 implementation
# isn't great, so it's disabled on ARM64.
AC_MSG_CHECKING([for HACL* SIMD128 implementation])
iftest "$UNIVERSAL_ARCHS" == "universal2"; then
if[[ "$build_cpu" == "aarch64" && "$build_vendor" == "apple" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please keep the "UNIVERSAL_ARCHS" test as well and usetest instead of[[ as it's more portable.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz left review comments

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aasland

@corona10corona10Awaiting requested review from corona10

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@naizhao@picnixz

[8]ページ先頭

©2009-2025 Movatter.jp