Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-134168: http.server with HTTPS fails to bind IPv6 addresses and ignores --directory flag#134169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ggqlq wants to merge11 commits intopython:mainChoose a base branch fromggqlq:fix_http_cli
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes from1 commit
Commits
Show all changes
11 commits Select commitHold shift + click to select a range
ee7abce
fix ipv6 and directory flag
ggqlqcf99f4d
check if ServerClass is a class
ggqlq26539a8
use a mixin class
ggqlqcf74a01
fix the check logic of ServerClass in the 'test' function
ggqlq0a96419
📜🤖 Added by blurb_it.
blurb-it[bot]7cf05e9
Update Lib/http/server.py
ggqlqebdd857
Update Misc/NEWS.d/next/Library/2025-05-18-13-23-29.gh-issue-134168.h…
ggqlq13f27ba
Merge branch 'main' into fix_http_cli
ggqlq5cdf539
Merge branch 'main' into fix_http_cli
ggqlq0fd2599
Merge branch 'main' into fix_http_cli
ggqlq6555d13
Merge branch 'main' into fix_http_cli
ggqlqFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
use a mixin class
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit26539a81ca10c8055238bd58f6d0b4a0c58dca36
There are no files selected for viewing
16 changes: 4 additions & 12 deletionsLib/http/server.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1039,7 +1039,7 @@ def test(HandlerClass=BaseHTTPRequestHandler, | ||
parser.error(f"Failed to read TLS password file: {e}") | ||
# ensure dual-stack is not disabled; ref #38907 | ||
classDualStackServerMixin: | ||
def server_bind(self): | ||
# suppress exception when protocol is IPv4 | ||
@@ -1052,18 +1052,10 @@ def finish_request(self, request, client_address): | ||
self.RequestHandlerClass(request, client_address, self, | ||
directory=args.directory) | ||
class HTTPDualStackServer(DualStackServerMixin, ThreadingHTTPServer): pass | ||
class HTTPSDualStackServer(DualStackServerMixin, ThreadingHTTPSServer): pass | ||
ggqlq marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
ServerClass = HTTPSDualStackServer if args.tls_cert elseHTTPDualStackServer | ||
test( | ||
HandlerClass=SimpleHTTPRequestHandler, | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.