Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-134168: http.server with HTTPS fails to bind IPv6 addresses and ignores --directory flag#134169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ggqlq wants to merge11 commits intopython:main
base:main
Choose a base branch
Loading
fromggqlq:fix_http_cli

Conversation

ggqlq
Copy link
Contributor

@ggqlqggqlq commentedMay 18, 2025•
edited by bedevere-appbot
Loading

I add a new HTTPSDualStackServer class(like 'DualStackServer') in _main function to handle IPv6 addresses and the--directory flag.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@ggqlqggqlq changed the titleFix http cligh134168: http.server with HTTPS fails to bind IPv6 addresses and ignores --directory flagMay 18, 2025
@ggqlqggqlq changed the titlegh134168: http.server with HTTPS fails to bind IPv6 addresses and ignores --directory flaggh-134168: http.server with HTTPS fails to bind IPv6 addresses and ignores --directory flagMay 18, 2025
@picnixz

This comment was marked as resolved.

@picnixz
Copy link
Member

And please add tests. I don't understand why--directory is being ignored in the first place.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

ggqlqand others added2 commitsMay 18, 2025 21:44
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…gx3Xg.rstCo-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@ggqlq
Copy link
ContributorAuthor

And please add tests. I don't understand why--directory is being ignored in the first place.

Should we move the runtime tests from PR#132540 to this one?

@picnixz
Copy link
Member

Oh I thought that the other PR was merged. NVM, i'll merge the other one so that you can extend the existing tests.

@picnixz
Copy link
Member

Ok, because we have some failures on the build bots, I've reverted the runtime tests but kept the static tests. Since this fix requires serving real files to check whether it works or not, I'll just assume that it locally works and be happy with it (I mean, what could go wrong?) I'm still planning to fix the runtime tests so that we can have a good coverage but it won't be a priority.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ggqlq@picnixz
[8]ページ先頭
©2009-2025 Movatter.jp