Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-133982: Run unclosed file test on all io implementations#134165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch todifferent I/O implementations.Update the `_pyio` implementation to match expected behavior, using thesame `_dealloc_warn` design as the C implementation uses to report thetopmost `__del__` object.
The FileIO one now matches all the others, so can use IOBase. There wasa missing check on closing (self._fd must be valid), add that check
5b0e827 intopython:main 39 checks passed
Uh oh!
There was an error while loading.Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 21, 2025
…thongh-134165)Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch todifferent I/O implementations.Update the `_pyio` implementation to match expected behavior, using thesame `_dealloc_warn` design as the C implementation uses to report thetopmost `__del__` object.The FileIO one now matches all the others, so can use IOBase. There wasa missing check on closing (self._fd must be valid), add that check(cherry picked from commit5b0e827)Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 21, 2025
…thongh-134165)Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch todifferent I/O implementations.Update the `_pyio` implementation to match expected behavior, using thesame `_dealloc_warn` design as the C implementation uses to report thetopmost `__del__` object.The FileIO one now matches all the others, so can use IOBase. There wasa missing check on closing (self._fd must be valid), add that check(cherry picked from commit5b0e827)Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
GH-134433 is a backport of this pull request to the3.14 branch. |
GH-134434 is a backport of this pull request to the3.13 branch. |
ambv pushed a commit that referenced this pull requestMay 21, 2025
…h-134165) (gh-134433)Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch todifferent I/O implementations.Update the `_pyio` implementation to match expected behavior, using thesame `_dealloc_warn` design as the C implementation uses to report thetopmost `__del__` object.The FileIO one now matches all the others, so can use IOBase. There wasa missing check on closing (self._fd must be valid), add that check(cherry picked from commit5b0e827)Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
ambv pushed a commit that referenced this pull requestMay 21, 2025
…h-134165) (gh-134434)Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch todifferent I/O implementations.Update the `_pyio` implementation to match expected behavior, using thesame `_dealloc_warn` design as the C implementation uses to report thetopmost `__del__` object.The FileIO one now matches all the others, so can use IOBase. There wasa missing check on closing (self._fd must be valid), add that check(cherry picked from commit5b0e827)Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Update
test_io_check_warn_on_deallocto useself.to dispatch to different I/O implementations.Update the
_pyioimplementation to match expected behavior, using the same_dealloc_warndesign as the C implementation uses to report the topmost__del__object.