NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

gh-71253: Run unclosed file test on all io implementations#134164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

cmaloney wants to merge1 commit intopython:mainfromcmaloney:pyio_dealloc_warn

Closed

gh-71253: Run unclosed file test on all io implementations#134164

cmaloney wants to merge1 commit intopython:mainfromcmaloney:pyio_dealloc_warn

Conversation

Copy link

Contributor

cmaloney commentedMay 18, 2025•
edited by bedevere-appbot
Loading

Updatetest_io_check_warn_on_dealloc to useself. to dispatch to different I/O implementations.

Update the_pyio implementation to match expected behavior, using the same_dealloc_warn design as the C implementation uses to report the topmost__del__ object.

Issue:SystemError if custom opener returns -1 #71253

pythongh-71253: Run unclosed file test on all io implementations

108b2bf

Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch todifferent I/O implementations.Update the `_pyio` implementation to match expected behavior, using thesame `_dealloc_warn` design as the C implementation uses to report thetopmost `__del__` object.