Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
GH-128520: pathlib ABCs: improve protocol for 'openable' objects#134101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
barneygale wants to merge2 commits intopython:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+114 −63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Rename `pathlib._os.magic_open()` to `vfsopen()`. The new name is a bitless abstract, and it aligns with the `vfspath()` method added in 5dbd27d.Per discussion on discourse[^1], adjust `vfsopen()` so that the followingmethods may be called:- `__open_reader__()`- `__open_writer__(mode)`- `__open_updater__(mode)`These three methods return readable, writable, and full duplex file objectsrespectively. In the 'writer' method, *mode* is either 'a', 'w' or 'x'. Inthe 'updater' method, *mode* is either 'r' or 'w'.Also stop trying built-in `open()` first. I don't know whether this is agood idea or not, so it's best to leave it out for now.In the pathlib ABCs, replace `ReadablePath.__open_rb__()` with`__open_reader__()`, and replace `WritablePath.__open_wb__()` with`__open_writer__()`.[^1]:https://discuss.python.org/t/open-able-objects/90238
17 tasks
Comment on lines +171 to +176
| try: | ||
| return cls.__open_reader__(obj) | ||
| except AttributeError: | ||
| if hasattr(cls, '__open_reader__'): | ||
| raise | ||
| raise TypeError(f"{cls.__name__} can't be opened for reading") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
try should contain only the operation operation that can fail (.):
Suggested change
| try: | |
| returncls.__open_reader__(obj) | |
| exceptAttributeError: | |
| ifhasattr(cls,'__open_reader__'): | |
| raise | |
| raiseTypeError(f"{cls.__name__} can't be opened for reading") | |
| try: | |
| open_reader=cls.__open_reader__ | |
| exceptAttributeError: | |
| raiseTypeError(f"{cls.__name__} can't be opened for reading") | |
| else: | |
| returnopen_reader(obj) |
| """ | ||
| Open the file pointed to by this path and return a file object, as | ||
| the built-in open() function does. | ||
| Unlike the built-in open() function, this function accepts 'openable' | ||
| objects, which are objects with any of these magic methods: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| objects,whichareobjectswithanyofthesemagicmethods: | |
| objects,whichareobjectswithanyofthesespecialmethods: |
Seethe glossary.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Rename
pathlib._os.magic_open()tovfsopen(). The new name is a bit less abstract, and it aligns with thevfspath()method added in5dbd27d.Per discussion on discourse1, adjust
vfsopen()so that the following methods may be called:__open_reader__()__open_writer__(mode)__open_updater__(mode)These three methods return readable, writable, and full duplex file objects respectively. In the 'writer' method,mode is either 'a', 'w' or 'x'. In the 'updater' method,mode is either 'r' or 'w'.
Also stop trying built-in
open()first. I don't know whether this is a good idea or not, so it's best to leave it out for now.In the pathlib ABCs, replace
ReadablePath.__open_rb__()with__open_reader__(), and replaceWritablePath.__open_wb__()with__open_writer__().Footnotes
https://discuss.python.org/t/open-able-objects/90238↩