Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-36953: Delay removal of ABCs from collections.#13409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Carreau
Copy link
Contributor

@CarreauCarreau commentedMay 18, 2019
edited
Loading

Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive to deprecated-removed.

https://bugs.python.org/issue36953

yan12125 reacted with thumbs up emoji
@jdemeyer
Copy link
Contributor

Why do we even have to say in advance when the functionality will be removed? For this deprecation, we already said we would remove it in 3.8 but we don't. So why are we now so certain that it will be removed in 3.9?

@Carreau
Copy link
ContributorAuthor

Why do we even have to say in advance when the functionality will be removed? For this deprecation, we already said we would remove it in 3.8 but we don't. So why are we now so certain that it will be removed in 3.9?

The policy is AFAICT removal n+2 after deprecation. We do have to remove at some point no? And adding the version number for removal make it easy to search for all that was marked for removal, as well as give expectation to readers.

In any case here we are just discussing bumping the version number, which should be less controversial than discussing if their should be one.

@ilevkivskyi
Copy link
Member

I think this deserves aMisc/NEWS item.

@Carreau
Copy link
ContributorAuthor

I think this deserves aMisc/NEWS item.

Why not... done.

@CarreauCarreau changed the titlebpo-25988: Delay removal of ABCs from collections.bpo-36953: Delay removal of ABCs from collections.May 20, 2019
Carreauand others added3 commitsMay 20, 2019 09:33
Bump the removal to 3.9, indicate collections.abc available since 3.3,replace version-changed directive tdeprecated-removed.
Co-Authored-By: Xtreak <tir.karthi@gmail.com>
@CarreauCarreauforce-pushed thebump-collections-abcs-removal branch from0ca83e5 toc34186dCompareMay 20, 2019 16:34
@Carreau
Copy link
ContributorAuthor

Title and commits were mentioning wrong issues; rebased/edited.

Copy link
Member

@ilevkivskyiilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for updates, LGTM!

@miss-islingtonmiss-islington merged commiteea47e0 intopython:masterMay 30, 2019
rhettinger pushed a commit that referenced this pull requestAug 22, 2019
This typo was introduced inGH-13409 when changing the message text.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 22, 2019
This typo was introduced inpythonGH-13409 when changing the message text.(cherry picked from commitc4106af)Co-authored-by: Florian Bruhin <me@the-compiler.org>
rhettinger pushed a commit that referenced this pull requestAug 22, 2019
This typo was introduced inGH-13409 when changing the message text.(cherry picked from commitc4106af)Co-authored-by: Florian Bruhin <me@the-compiler.org>
lisroach pushed a commit to lisroach/cpython that referenced this pull requestSep 10, 2019
This typo was introduced inpythonGH-13409 when changing the message text.
@miss-islington
Copy link
Contributor

Thanks@Carreau for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-16675 is a backport of this pull request to the3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 9, 2019
Bump the removal to 3.9, indicate collections.abc available since 3.3,replace version-changed directive to deprecated-removed.https://bugs.python.org/issue36953(cherry picked from commiteea47e0)Co-authored-by: Matthias Bussonnier <mbussonnier@ucmerced.edu>
miss-islington added a commit that referenced this pull requestOct 9, 2019
Bump the removal to 3.9, indicate collections.abc available since 3.3,replace version-changed directive to deprecated-removed.https://bugs.python.org/issue36953(cherry picked from commiteea47e0)Co-authored-by: Matthias Bussonnier <mbussonnier@ucmerced.edu>
ned-deily pushed a commit to ned-deily/cpython that referenced this pull requestOct 14, 2019
Bump the removal to 3.9, indicate collections.abc available since 3.3,replace version-changed directive to deprecated-removed.https://bugs.python.org/issue36953(cherry picked from commiteea47e0)Co-authored-by: Matthias Bussonnier <mbussonnier@ucmerced.edu>
DinoV pushed a commit to DinoV/cpython that referenced this pull requestJan 14, 2020
Bump the removal to 3.9, indicate collections.abc available since 3.3,replace version-changed directive to deprecated-removed.https://bugs.python.org/issue36953
DinoV pushed a commit to DinoV/cpython that referenced this pull requestJan 14, 2020
This typo was introduced inpythonGH-13409 when changing the message text.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull requestJul 20, 2020
This typo was introduced inpythonGH-13409 when changing the message text.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tirkarthitirkarthitirkarthi left review comments

@asvetlovasvetlovasvetlov approved these changes

@ilevkivskyiilevkivskyiilevkivskyi approved these changes

@rhettingerrhettingerAwaiting requested review from rhettinger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Carreau@jdemeyer@ilevkivskyi@miss-islington@bedevere-bot@asvetlov@tirkarthi@serhiy-storchaka@the-knights-who-say-ni@csabella

[8]ページ先頭

©2009-2025 Movatter.jp