Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-132124: improve safety nets for creating AF_UNIX socket files#134085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
When you're done making the requested changes, leave the comment: |
3233fdc to84f7020CompareI have made the requested changes; please review again. |
Thanks for making the requested changes! @gpshead: please review the changes made to this pull request. |
Thank you! It works (and the change seems to have the semantics I'd expect). |
| @@ -19,7 +19,7 @@ | |||
| from . import process | |||
| __all__ = [ | |||
| 'sub_debug', 'debug', 'info', 'sub_warning', 'get_logger', | |||
| 'sub_debug', 'debug', 'info', 'sub_warning', 'warn', 'get_logger', | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
note to self: I'm going to leave 'warn' out of__all__ and rename the function to_warn as a modification to our 3.13 backport as it'd technically be an API change in a bugfix release otherwise.
1a07a01 intopython:mainUh oh!
There was an error while loading.Please reload this page.
pythonGH-134085)* ensure that we can create AF_UNIX socket files* emit a warning if system-wide temporary directory is used(cherry picked from commit1a07a01)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
GH-134447 is a backport of this pull request to the3.14 branch. |
pythonGH-134085)* ensure that we can create AF_UNIX socket files* emit a warning if system-wide temporary directory is used(cherry picked from commit1a07a01)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
GH-134448 is a backport of this pull request to the3.13 branch. |
…es (GH-134085) (#134447)gh-132124: improve safety nets for creating AF_UNIX socket files (GH-134085)* ensure that we can create AF_UNIX socket files* emit a warning if system-wide temporary directory is used(cherry picked from commit1a07a01)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
cc@Poupine@thesamesam@mmokrejs
multiprocessing.util.get_temp_dir()can be used to create socket files with limited path length #132124