Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133374: fix test_python_legacy_windows_stdio#134080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

methane
Copy link
Member

@methanemethane commentedMay 16, 2025•
edited by bedevere-appbot
Loading

@chris-eibl
Copy link
Member

See also#133375.

Copy link
Member

@zoobazooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is closer to being ready than the other PR, IMHO. So up to the two contributors to see who gets there first :)

@methanemethane changed the titlefix test_python_legacy_windows_stdiogh-133374: fix test_python_legacy_windows_stdioMay 16, 2025
@methane
Copy link
MemberAuthor

Should we usecreationflags=subprocess.CREATE_NEW_CONSOLE only whennot os.isatty(sys.stdin)?

When a Windows developer runs a test on the console, will a new annoying console appear for a moment? (I cannot run test on Windows Desktop soon.)

@zooba
Copy link
Member

When a Windows developer runs a test on the console, will a new annoying console appear for a moment?

It will, but don't we have a resource for this already?

If the new console doesn't appear, annoying characters get typed over the test results for some similar tests. So I'm pretty sure they're all behind a resource.

@methanemethane merged commit652d693 intopython:mainMay 20, 2025
44 checks passed
@serhiy-storchakaserhiy-storchaka added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 20, 2025
@miss-islington-app
Copy link

Thanks@methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks@methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry,@methane, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 652d6938ef8c42c1c4c180c3f0e257c26c6677da 3.13

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2025
(cherry picked from commit652d693)Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@bedevere-app
Copy link

GH-134314 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 20, 2025
@serhiy-storchakaserhiy-storchaka removed the needs backport to 3.13bugs and security fixes labelMay 20, 2025
serhiy-storchaka pushed a commit that referenced this pull requestMay 20, 2025
…H-134314)(cherry picked from commit652d693)Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@zoobazoobazooba approved these changes

Assignees

@methanemethane

Labels
OS-windowsskip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@methane@chris-eibl@zooba@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp