Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-115119: removed implicit fallback to the bundled libmpdec#134078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
gh-115119: removed implicit fallback to the bundled libmpdec#134078
Conversation
skirpichev commentedMay 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
On top of configure changes in#133997. N/B: all linux jobs, except for changed (not sure if it worth) - haveno system libmpdec. For MacOS we run tests with system libmpdec. |
Uh oh!
There was an error while loading.Please reload this page.
| [AC_MSG_WARN([m4_normalize([ | ||
| no system libmpdecimal found; falling back tobundled libmpdecimal | ||
| (deprecated and scheduledforremoval in Python 3.15)])]) | ||
| USE_BUNDLED_LIBMPDEC()]) | ||
| no system libmpdecimal found; falling back topure-Python version | ||
| forthe decimal module])]) | ||
| AS_VAR_SET([py_cv_module_]_decimal, [n/a])]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
AC_MSG_ERROR? I think opting in to the pure Python version should be explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
AC_MSG_ERROR ?
Well, that could be an option.
Though, more complex wrt implementation: all linux jobs will fail, unless we either provide system libmpdec or change ./configure invocations to use a new option.
I think opting in to the pure Python version should be explicit.
I'm not sure it's useful. After all, the pure-Python version is always available as the_pydecimal.py.
Did you suggest a new option like--with-purepython-decimal?
Uh oh!
There was an error while loading.Please reload this page.
libmpdecsources #115119📚 Documentation preview 📚:https://cpython-previews--134078.org.readthedocs.build/