Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Docs EPUB: fix meta tags connected with Open Graph#134071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
For EPUB builds validity.
Do meta tags even make sense for EPUB (and other builders)? If not, it's probably better to skip them altogether for those builders. Could save us future headaches as well. |
It looks like they don't.https://chatgpt.com/share/6827445c-70f0-8004-bed3-353546e96afa sphinx-doc/sphinxext-opengraph#137@methane started the implementation of skipping them on the extension side. |
I'd prefer an authoritative source rather than a webpage that says "ChatGPT can make mistakes. Check important info." |
I wasn't able to confirm that searching manually in a limited time. |
Uh oh!
There was an error while loading.Please reload this page.
theme-colortag fromsphinxext-opengraphcustom tags config directly tolayout.html. Previously it would be added for all HTML-related Sphinx builders, after it's only added when builder == HTML.sphinxext-opengraphconfig. (I've openedCustom tags and EPUB builder sphinx-doc/sphinxext-opengraph#136 to discuss alternative fixes.)It's a follow-up to#132220 and#133720. This change should fix EPUB builds. When testing locally for#133720 I didn't have
sphinxext-opengraphinstalled in the environment, that's why I didn't catch it earlier, I'm sorry.Could we please backport it for supported versions and 3.12?
Before:
After:
📚 Documentation preview 📚:https://cpython-previews--134071.org.readthedocs.build/