Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.14] gh-134060: Don't create a certain symlink invenv if platform does not support it#134061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIrelandStanFromIreland commentedMay 15, 2025
edited
Loading

Should this get a NEWS since it is asensitive topic?

I think just checking for utf8 is simplest and will cover most platforms, rather than complicated methods for an easter egg symlink (It's not worth it IMO).

Request@hugovk@hauntsaninja

@StanFromIreland
Copy link
ContributorAuthor

StanFromIreland commentedMay 15, 2025
edited
Loading

Running!buildbot rasbian (!buildbot ARM64 Raspbian should in theory call the exact one we want, but might be dangerous as it may call allARM64 buildbots?) will confirm the fix.

@StanFromIreland
Copy link
ContributorAuthor

Maybe@serhiy-storchaka is interested since you are working on similar instances.

@ZeroIntensity
Copy link
Member

!buildbot rasbian

@bedevere-bot
Copy link

The regex 'rasbian' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@ZeroIntensity
Copy link
Member

!buildbot raspbian

StanFromIreland reacted with heart emoji

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@ZeroIntensity for commit41af4a9 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134061%2Fmerge

The command will test the builders whose names match following regular expression:raspbian

The builders matched are:

  • ARM Raspbian PR
  • ARM64 Raspbian PR

@StanFromIreland
Copy link
ContributorAuthor

Before:

9 tests failed:    test_cext test_cppext test_httpservers test_peg_generator    test_strftime test_strptime test_sysconfig test_time test_venv461 tests OK.

After (str[p,f]time,time unrelated, I changed the config):

1 test failed:    test_httpservers469 tests OK.

Copy link
Contributor

@hauntsaninjahauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! This seems reasonable to me and it looks like PEP 529 means it will work on Windows as well

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@StanFromIreland
Copy link
ContributorAuthor

Anything else left to do here?

@serhiy-storchakaserhiy-storchaka merged commit91d71ac intopython:3.14May 18, 2025
49 of 50 checks passed
@StanFromIrelandStanFromIreland deleted the fixnoteasteregg branchMay 18, 2025 19:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@hauntsaninjahauntsaninjahauntsaninja approved these changes

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

@FFY00FFY00Awaiting requested review from FFY00FFY00 is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@StanFromIreland@ZeroIntensity@bedevere-bot@serhiy-storchaka@hauntsaninja

[8]ページ先頭

©2009-2025 Movatter.jp