Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133157: remove use of_Py_NO_SANITIZE_UNDEFINED in faulthandler#134047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 3 commits intopython:mainfrompicnixz:fix/ubsan/faulthandler-133157
May 18, 2025

Conversation

picnixz
Copy link
Member

@picnixzpicnixz commentedMay 15, 2025•
edited
Loading

  • remove_read_null() as it's a tricky one (and the compiler didn't seem to complain)
  • instead of using 1/0 arithmetic, we explicitly raise SIGFPE

- reading from NULL is no more an undefined behavior for C11- instead of using 1/0 arithmetic, we explicitly raise SIGFPE
Reading from NULL is an undefined behavior and `faulthandler`should not check for low-level C about undefined behaviors.
@picnixzpicnixz requested a review fromvstinnerMay 16, 2025 09:03
@picnixz
Copy link
MemberAuthor

Should I actually add a NEWS entry? the function was not documented but it had a docstring.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@vstinner
Copy link
Member

Should I actually add a NEWS entry? the function was not documented but it had a docstring.

It doesn't need a NEWS entry since it's a private function written for test_faulthandler.

@picnixzpicnixz merged commit0a160bf intopython:mainMay 18, 2025
42 checks passed
@picnixzpicnixz deleted the fix/ubsan/faulthandler-133157 branchMay 18, 2025 08:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@encukouencukouAwaiting requested review from encukou

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@picnixz@vstinner
[8]ページ先頭
©2009-2025 Movatter.jp