Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-134069: bump HACL* revision to incoporatememset_s
#134027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-134069: bump HACL* revision to incoporatememset_s
#134027
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've tagged this for back port to 3.14; it doesn't need a news file, but because it's going to involve a back port, we do need a ticket so we have a point of coordination for multiple commits making the "same" change. That would also be a good opportunity to give a high level summary of what has changed - from the look of it, it's the Mac constants, plus some code formatting changes - but it would be good to have a high level summary to confirm that (and then update the PR title to startgh-XXX
with the ticket number):
There's also something going on with SBOM checks on Windows - from the look of it, you've updated all the hashes for the individual files, but not the hash for the source HACL* tarball that contains the origin of these changes.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This fixes building with legacy/cross-platform macOS SDKs.Signed-off-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>
a5fba02
tob96621f
Comparememset_s
I have made the requested changes; please review again |
Thanks for making the requested changes! @freakboy3742: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 Thanks for those changes - that all looks good now! The merge back to 3.14 should happen soon after this PR lands; watch the comments on this PR for updates.
1566c34
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@aeiouaeiouaeiouaeiouaeiouaeiou for the PR, and@freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…GH-134027)Bumps the HACL* revision to include recent revisions that corrects issuesbuilding with legacy/cross-platform macOS SDKs.(cherry picked from commit1566c34)Co-authored-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>Signed-off-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>
GH-134084 is a backport of this pull request to the3.14 branch. |
…4027) (#134084)Bumps the HACL* revision to include recent revisions that corrects issuesbuilding with legacy/cross-platform macOS SDKs.(cherry picked from commit1566c34)Signed-off-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>Co-authored-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>
Uh oh!
There was an error while loading.Please reload this page.
Also, it would also be nice if this commit was cherry-picked to
3.14
branch.CC@freakboy3742@msprotz