Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-134069: bump HACL* revision to incoporatememset_s#134027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

@aeiouaeiouaeiouaeiouaeiouaeiouaeiouaeiouaeiouaeiouaeiouaeiou commentedMay 15, 2025
edited by bedevere-appbot
Loading

Also, it would also be nice if this commit was cherry-picked to3.14 branch.

CC@freakboy3742@msprotz

Copy link
Contributor

@freakboy3742freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've tagged this for back port to 3.14; it doesn't need a news file, but because it's going to involve a back port, we do need a ticket so we have a point of coordination for multiple commits making the "same" change. That would also be a good opportunity to give a high level summary of what has changed - from the look of it, it's the Mac constants, plus some code formatting changes - but it would be good to have a high level summary to confirm that (and then update the PR title to startgh-XXX with the ticket number):

There's also something going on with SBOM checks on Windows - from the look of it, you've updated all the hashes for the individual files, but not the hash for the source HACL* tarball that contains the origin of these changes.

aeiouaeiouaeiouaeiouaeiouaeiou reacted with thumbs up emoji
@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

This fixes building with legacy/cross-platform macOS SDKs.Signed-off-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>
@picnixzpicnixz changed the titleBump the HACL* revision.gh-134069: bump the HACL* revisionMay 15, 2025
@picnixzpicnixz changed the titlegh-134069: bump the HACL* revisiongh-134069: bump HACL* revision to incoporatememset_sMay 15, 2025
@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-app
Copy link

Thanks for making the requested changes!

@freakboy3742: please review the changes made to this pull request.

Copy link
Contributor

@freakboy3742freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 Thanks for those changes - that all looks good now! The merge back to 3.14 should happen soon after this PR lands; watch the comments on this PR for updates.

aeiouaeiouaeiouaeiouaeiouaeiou reacted with hooray emoji
@freakboy3742freakboy3742 merged commit1566c34 intopython:mainMay 16, 2025
44 of 47 checks passed
@miss-islington-app
Copy link

Thanks@aeiouaeiouaeiouaeiouaeiouaeiou for the PR, and@freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 16, 2025
…GH-134027)Bumps the HACL* revision to include recent revisions that corrects issuesbuilding with legacy/cross-platform macOS SDKs.(cherry picked from commit1566c34)Co-authored-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>Signed-off-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>
@bedevere-app
Copy link

GH-134084 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 16, 2025
freakboy3742 pushed a commit that referenced this pull requestMay 16, 2025
…4027) (#134084)Bumps the HACL* revision to include recent revisions that corrects issuesbuilding with legacy/cross-platform macOS SDKs.(cherry picked from commit1566c34)Signed-off-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>Co-authored-by: aeiouaeiouaeiouaeiouaeiouaeiou <aeioudev@outlook.com>
@aeiouaeiouaeiouaeiouaeiouaeiouaeiouaeiouaeiouaeiouaeiouaeiou deleted the hacl-star-2025-05 branchMay 16, 2025 11:33
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@freakboy3742freakboy3742freakboy3742 approved these changes

@sethmlarsonsethmlarsonAwaiting requested review from sethmlarsonsethmlarson is a code owner

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner

@picnixzpicnixzAwaiting requested review from picnixzpicnixz is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aeiouaeiouaeiouaeiouaeiouaeiou@freakboy3742

[8]ページ先頭

©2009-2025 Movatter.jp