Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-76595: Add note onPyCapsule_Import behavior#134022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

NicolasT
Copy link
Contributor

@NicolasTNicolasT commentedMay 14, 2025
edited by ZeroIntensity
Loading

I was somewhat surprised by this behavior recently, so thought it'd be useful to have a note in the docs.

There's a PR (GH-6898) which changes this behavior (to be less surprising, I believe), but this seems to have stalled.

See:#76595
See:#6898


📚 Documentation preview 📚:https://cpython-previews--134022.org.readthedocs.build/en/134022/c-api/capsule.html#c.PyCapsule_Import

There's a PR (pythonGH-6898) which changes this behavior (to be lesssurprising, I believe), but this seems to have stalled.See:python#76595See:python#6898
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we should split up the note. The behavior regarding attribute lookups should go in the canonical description of the function, and then the gotcha about imports should be in the note.

@NicolasT
Copy link
ContributorAuthor

Thanks for the feedback. I tried to handle both of the requested changes.

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm happy with this. Someone else is free to nitpick the wording here.

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Reapplying my review. I'll merge this tomorrow if there aren't any objections to the wording.

@ZeroIntensityZeroIntensity merged commit579acf4 intopython:mainJun 28, 2025
25 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsJun 28, 2025
@miss-islington-app
Copy link

Thanks@NicolasT for the PR, and@ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 28, 2025
)(cherry picked from commit579acf4)Co-authored-by: Nicolas Trangez <ikke@nicolast.be>
@bedevere-app
Copy link

GH-136074 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJun 28, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 28, 2025
)(cherry picked from commit579acf4)Co-authored-by: Nicolas Trangez <ikke@nicolast.be>
@bedevere-app
Copy link

GH-136075 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJun 28, 2025
ZeroIntensity pushed a commit that referenced this pull requestJun 28, 2025
…H-136075)gh-76595: Add note on `PyCapsule_Import` behavior (GH-134022)(cherry picked from commit579acf4)Co-authored-by: Nicolas Trangez <ikke@nicolast.be>
ZeroIntensity pushed a commit that referenced this pull requestJun 28, 2025
…H-136074)gh-76595: Add note on `PyCapsule_Import` behavior (GH-134022)(cherry picked from commit579acf4)Co-authored-by: Nicolas Trangez <ikke@nicolast.be>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip newstopic-C-API
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@NicolasT@ZeroIntensity@StanFromIreland

[8]ページ先頭

©2009-2025 Movatter.jp