Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-115119: defer removal of bundled libmpdec to 3.16#133997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Oops, this seems to be not just a docs patch. I hope this still ok for backport. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't have much to say but I'm neutral on delaying the removal.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
What is the rationale for defering the removal? |
You can see the issue thread. For my humble opinion the only excuse is that we miss removal of the implicit fallback to bundled copy (now#134078) in 3.14. (Though, this wasn't announced somewhere else.) We also miss libmpdec in latest ubuntu images. (I think this will be solved before 3.14 release.) |
I still think we can stick to the original plan (that is: remove the vendored copy in 3.15). The only issue to solve is installing development sources on Ubuntu for 24.04. |
FYI, I restored removal PR:#133964. I think libmpdec can be installed from PPA for PHP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
This, probably, requires approval from the release manager. Though,@hugovk removed request for review. |
Deferring a breaking change is always a good thing :-) |
An RM decision isn't needed for normal feature changes in https://devguide.python.org/developer-workflow/development-cycle/#in-development-main-branch |
Maybe.
This affects 3.14 as well, as we change announced plans. |
Since#134078 was just merged in Python 3.15, I think that it would be safe to postpone the removal to Python 3.16. Have one release with#134078 to see how it goes. @skirpichev: There are now merge conflicts, can you try to address them? |
Oops, now it doesn't make less sense to backport this (configure.ac changes will be manual). It's expected to be merged first, not after#134078. |
b19c9da
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Merged.
Do you mean that it doesn't make sense to backport this change, or that it should be backported manually? |
No, it does!
Yes. I'll do this. |
…thonGH-133997)Rename libmpdecimal -> libmpdecseehttps://www.bytereef.org/mpdecimal/doc/libmpdec/index.html(cherry picked from commitb19c9da)Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
GH-136199 is a backport of this pull request to the3.14 branch. |
…thonGH-133997)Rename libmpdecimal -> libmpdecseehttps://www.bytereef.org/mpdecimal/doc/libmpdec/index.html(cherry picked from commitb19c9da)Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
GH-136201 is a backport of this pull request to the3.13 branch. |
Uh oh!
There was an error while loading.Please reload this page.
libmpdec
sources #115119📚 Documentation preview 📚:https://cpython-previews--133997.org.readthedocs.build/