Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-115119: defer removal of bundled libmpdec to 3.16#133997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

skirpichev
Copy link
Contributor

@skirpichevskirpichev commentedMay 14, 2025
edited by github-actionsbot
Loading

@skirpichevskirpichev added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 14, 2025
@bedevere-appbedevere-appbot added the docsDocumentation in the Doc dir labelMay 14, 2025
@bedevere-appbedevere-appbot mentioned this pull requestMay 14, 2025
15 tasks
@skirpichevskirpichev requested a review fromhugovkMay 15, 2025 06:47
@skirpichev
Copy link
ContributorAuthor

Oops, this seems to be not just a docs patch. I hope this still ok for backport.

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't have much to say but I'm neutral on delaying the removal.

@hugovkhugovk removed their request for reviewJune 2, 2025 11:06
@vstinner
Copy link
Member

defer removal of bundled libmpdec to 3.16

What is the rationale for defering the removal?

@skirpichev
Copy link
ContributorAuthor

What is the rationale for defering the removal?

You can see the issue thread.

For my humble opinion the only excuse is that we miss removal of the implicit fallback to bundled copy (now#134078) in 3.14. (Though, this wasn't announced somewhere else.) We also miss libmpdec in latest ubuntu images. (I think this will be solved before 3.14 release.)

@AA-Turner
Copy link
Member

For my humble opinion the only excuse is that we miss removal of the implicit fallback to bundled copy

I still think we can stick to the original plan (that is: remove the vendored copy in 3.15). The only issue to solve is installing development sources on Ubuntu for 24.04.

@skirpichev
Copy link
ContributorAuthor

FYI, I restored removal PR:#133964. I think libmpdec can be installed from PPA for PHP.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@skirpichev
Copy link
ContributorAuthor

This, probably, requires approval from the release manager. Though,@hugovk removed request for review.

@vstinner
Copy link
Member

This, probably, requires approval from the release manager. Though,@hugovk removed request for review.

Deferring a breaking change is always a good thing :-)

@hugovk
Copy link
Member

An RM decision isn't needed for normal feature changes inmain aka 3.15. (And if it's deferred to 3.16, it's even less of this RM's decision :)

https://devguide.python.org/developer-workflow/development-cycle/#in-development-main-branch

@skirpichev
Copy link
ContributorAuthor

Deferring a breaking change is always a good thing :-)

Maybe.

An RM decision isn't needed for normal feature changes in main aka 3.15.

This affects 3.14 as well, as we change announced plans.

@vstinner
Copy link
Member

Since#134078 was just merged in Python 3.15, I think that it would be safe to postpone the removal to Python 3.16. Have one release with#134078 to see how it goes.

@skirpichev: There are now merge conflicts, can you try to address them?

@skirpichevskirpichev removed needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJul 1, 2025
@skirpichev
Copy link
ContributorAuthor

Oops, now it doesn't make less sense to backport this (configure.ac changes will be manual). It's expected to be merged first, not after#134078.

@skirpichevskirpichev added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJul 1, 2025
@skirpichevskirpichev requested a review fromvstinnerJuly 1, 2025 16:42
@vstinnervstinner removed needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJul 2, 2025
@vstinnervstinner merged commitb19c9da intopython:mainJul 2, 2025
44 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsJul 2, 2025
@vstinner
Copy link
Member

Merged.

Oops, now it doesn't make less sense to backport this (configure.ac changes will be manual).

Do you mean that it doesn't make sense to backport this change, or that it should be backported manually?

@skirpichevskirpichev deleted the defer-libmpdec-removal/115119 branchJuly 2, 2025 09:32
@skirpichev
Copy link
ContributorAuthor

Do you mean that it doesn't make sense to backport this change

No, it does!

that it should be backported manually?

Yes. I'll do this.

vstinner reacted with thumbs up emoji

skirpichev added a commit to skirpichev/cpython that referenced this pull requestJul 2, 2025
…thonGH-133997)Rename libmpdecimal -> libmpdecseehttps://www.bytereef.org/mpdecimal/doc/libmpdec/index.html(cherry picked from commitb19c9da)Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

GH-136199 is a backport of this pull request to the3.14 branch.

skirpichev added a commit to skirpichev/cpython that referenced this pull requestJul 2, 2025
…thonGH-133997)Rename libmpdecimal -> libmpdecseehttps://www.bytereef.org/mpdecimal/doc/libmpdec/index.html(cherry picked from commitb19c9da)Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

GH-136201 is a backport of this pull request to the3.13 branch.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-Turner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

@picnixzpicnixzAwaiting requested review from picnixz

@vstinnervstinnerAwaiting requested review from vstinner

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@skirpichev@vstinner@AA-Turner@hugovk@picnixz@StanFromIreland

[8]ページ先頭

©2009-2025 Movatter.jp