Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-72902: improve Fraction(str) speed (don't use regexp's)#133994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
skirpichev wants to merge9 commits intopython:mainChoose a base branch fromskirpichev:speedup-Fraction-fromstr/72902
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+55 −38
Open
Changes from1 commit
Commits
Show all changes
9 commits Select commitHold shift + click to select a range
b45b672
gh-72902: improve Fraction(str) speed (don't use regexp's)
skirpichevd6b0083
Update Lib/fractions.py
skirpichev05e9110
+ a quick fix
skirpichev7c567fc
Update Lib/fractions.py
skirpichevcb679a0
Merge branch 'master' into speedup-Fraction-fromstr/72902
skirpicheve383bdb
address review: add test
skirpicheva617212
Merge branch 'master' into speedup-Fraction-fromstr/72902
skirpichev48f73f0
+ revert moving numbers.Rational check
skirpichev20436d8
+1
skirpichevFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
+ revert moving numbers.Rational check
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit48f73f01b2279258deec0bb06ffb765072097f18
There are no files selected for viewing
10 changes: 5 additions & 5 deletionsLib/fractions.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.