Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-106213: Shorten Emscripten wasm-gc trampoline by a little#133984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
freakboy3742 merged 1 commit intopython:mainfromhoodmane:shorter-emscripten-wasm-gc-trampolineMay 20, 2025
Merged
gh-106213: Shorten Emscripten wasm-gc trampoline by a little#133984
freakboy3742 merged 1 commit intopython:mainfromhoodmane:shorter-emscripten-wasm-gc-trampolineMay 20, 2025
+21 −37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
I found out about the `if` instruction which lets us have slightlyshorter code here.
5680660 tode6ffa6Comparefreakboy3742 approved these changesMay 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
3b7888b intopython:main 46 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@hoodmane for the PR, and@freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2025
…ythonGH-133984)Using the if instruction results in slightly shorter trampoline code.(cherry picked from commit3b7888b)Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
GH-134376 is a backport of this pull request to the3.14 branch. |
freakboy3742 pushed a commit that referenced this pull requestMay 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I found out about the
ifinstruction which lets us have slightly shorter code here.