Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-115119: Removed bundled copy of the libmpdec#133964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

skirpichev
Copy link
Contributor

@skirpichevskirpichev commentedMay 13, 2025•
edited by github-actionsbot
Loading

@bedevere-appbedevere-appbot mentioned this pull requestMay 13, 2025
15 tasks
@skirpichevskirpichevforce-pushed theremove-bundled-mpdecimal/115119 branch from7cba56a to9d6c9b5CompareMay 13, 2025 15:37
Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

quick comments, haven't looked at build system changes

Comment on lines -838 to -852
.. option:: --with-system-libmpdec

Build the ``_decimal`` extension module using an installed ``mpdecimal``
library, see the :mod:`decimal` module (default is yes).

.. versionadded:: 3.3

.. versionchanged:: 3.13
Default to using the installed ``mpdecimal`` library.

.. deprecated-removed:: 3.13 3.15
A copy of the ``mpdecimal`` library sources will no longer be distributed
with Python 3.15.

.. seealso:: :option:`LIBMPDEC_CFLAGS` and :option:`LIBMPDEC_LIBS`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wonder if it's worth keeping a mention of--with-system-libmpdec, just for the purpose of saying it's been removed? Unsure though.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is this something that expected for removed stuff?

I see one removed option,--with-wctype-functions - it's only in whatsnew.

skirpichevand others added2 commitsMay 13, 2025 19:21
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app

This comment was marked as resolved.

@AA-Turner
Copy link
Member

Ubuntu is failing as version 24.04 doesn't have a libmpdec-dev package so the_decimal module isn't built. 25.04 and the upcoming 25.10 do have the mpdecimal sources, though. I don't know enough about Ubuntu packaging to work out how to install those packages on 24.04 (or the version from 22.04).

A

@skirpichev

This comment was marked as resolved.

@bedevere-app

This comment was marked as resolved.

@bedevere-appbedevere-appbot requested a review fromzwareMay 14, 2025 03:41
@skirpichev
Copy link
ContributorAuthor

skirpichev commentedMay 14, 2025•
edited
Loading

Ubuntu is failing as version 24.04 doesn't have a libmpdec-dev package so the _decimal module isn't built.

Yes. One solution is build it for CI by usual "./configure && make && make install". Other - filter out the_decimal module from theTools/build/check_extension_modules.py output. Not sure how to do this, PY_STDLIB_MOD_SET_NA? Probably it should be disabled (with a warning) if libmpdec is missing.

Edit: I did proposed (module marked as n/a if libmpdec is missing). One Linux job works now on the ubuntu 22.04, which has an appropriate libmpdec version.

PS:
But see the discussion thread: it was proposed to postpone removal for yet another release.

@skirpichevskirpichevforce-pushed theremove-bundled-mpdecimal/115119 branch from0a33f9f to2ba6b8bCompareMay 14, 2025 05:49
@skirpichevskirpichev deleted the remove-bundled-mpdecimal/115119 branchMay 16, 2025 04:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@zwarezwareAwaiting requested review from zware

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@sethmlarsonsethmlarsonAwaiting requested review from sethmlarsonsethmlarson will be requested when the pull request is marked ready for reviewsethmlarson is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently will be requested when the pull request is marked ready for reviewericsnowcurrently is a code owner

@1st11st1Awaiting requested review from 1st11st1 will be requested when the pull request is marked ready for review1st1 is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland will be requested when the pull request is marked ready for reviewerlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 will be requested when the pull request is marked ready for reviewcorona10 is a code owner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti will be requested when the pull request is marked ready for reviewezio-melotti is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk will be requested when the pull request is marked ready for reviewhugovk is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@skirpichev@AA-Turner@zware
[8]ページ先頭
©2009-2025 Movatter.jp