Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132983: Call Py_XDECREF rather than PyObject_GC_Del in failed __new__#133962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 1 commit intopython:mainfromencukou:zstd-new-refleak
May 13, 2025

Conversation

encukou
Copy link
Member

@encukouencukou commentedMay 13, 2025•
edited by bedevere-appbot
Loading

This will call tp_dealloc and clear all members.

This will call tp_dealloc and clear all members.
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

See alsohttps://github.com/python/cpython/pull/133924/files#r2084922874

There may be other similar errors in these files.

@encukou
Copy link
MemberAuthor

I'll merge to fix the tier-1 buildbot; further fix-ups welcome.

@encukouencukou merged commite575190 intopython:mainMay 13, 2025
42 checks passed
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.14bugs and security fixes labelMay 13, 2025
@miss-islington-app
Copy link

Thanks@encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@encukou, I could not cleanly backport this to3.14 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker e575190abbd9409adad3e7fd95424f827236bed9 3.14

@AA-Turner
Copy link
Member

Thanks for the fix & merge@encukou -- backport will fail as the original commit isn't yet backported.

@AA-TurnerAA-Turner added needs backport to 3.14bugs and security fixes and removed needs backport to 3.14bugs and security fixes labelsMay 20, 2025
@miss-islington-app
Copy link

Thanks@encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2025
…d __new__ (pythonGH-133962)Call Py_XDECREF rather than PyObject_GC_Del in failed __new__This will call tp_dealloc and clear all members.(cherry picked from commite575190)Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

GH-134305 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 20, 2025
AA-Turner pushed a commit that referenced this pull requestMay 20, 2025
…ed __new__ (GH-133962) (#134305)gh-132983: Call Py_XDECREF rather than PyObject_GC_Del in failed __new__ (GH-133962)Call Py_XDECREF rather than PyObject_GC_Del in failed __new__This will call tp_dealloc and clear all members.(cherry picked from commite575190)Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-Turner

Assignees

@encukouencukou

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@encukou@AA-Turner@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp