Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132983: Fix zstd compiler warning about unused function mt_continue_should_break()#133947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 1 commit intopython:mainfromerlend-aasland:zstd-warning
May 12, 2025

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedMay 12, 2025•
edited
Loading

Fixes the following compiler warning:

./Modules/_zstd/compressor.c:490:1: warning: unused function 'mt_continue_should_break' [-Wunused-function]  490 | mt_continue_should_break(ZSTD_inBuffer *in, ZSTD_outBuffer *out)      | ^~~~~~~~~~~~~~~~~~~~~~~~1 warning generated.

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commentedMay 12, 2025•
edited
Loading

AFAICS,mt_continue_should_break is only used in an assert, so we can safely only define it if we're debugging.

Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry, I didn't see this compiler warning locally (do you need different flags for it?).

A

@AA-TurnerAA-Turner added the needs backport to 3.14bugs and security fixes labelMay 12, 2025
@AA-TurnerAA-Turner merged commit121ed71 intopython:mainMay 12, 2025
48 checks passed
@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 12, 2025
…inue_should_break()`` (pythonGH-133947)(cherry picked from commit121ed71)Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-app
Copy link

GH-133950 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 12, 2025
@erlend-aaslanderlend-aasland deleted the zstd-warning branchMay 12, 2025 19:24
AA-Turner pushed a commit that referenced this pull requestMay 12, 2025
…tinue_should_break()`` (GH-133947) (#133950)gh-132983: Fix compiler warning about unused function ``mt_continue_should_break()`` (GH-133947)(cherry picked from commit121ed71)Co-authored-by: Erlend E. Aasland <erlend@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAA-Turner approved these changes

@emmatypingemmatypingemmatyping approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@erlend-aasland@AA-Turner@emmatyping
[8]ページ先頭
©2009-2025 Movatter.jp