Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133904: math.factorial documentation fix#133907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 6 commits intopython:mainfrommkaraev:ghissue-133904
May 12, 2025

Conversation

mkaraev
Copy link
Contributor

@mkaraevmkaraev commentedMay 11, 2025•
edited by ZeroIntensity
Loading

@python-cla-bot
Copy link

python-cla-botbot commentedMay 11, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-appbedevere-appbot added docsDocumentation in the Doc dir skip news awaiting review labelsMay 11, 2025
@mkaraevmkaraev changed the titlemath.factorial documentation fixgh-133904: math.factorial documentation fixMay 11, 2025
@mkaraev
Copy link
ContributorAuthor

mkaraev commentedMay 11, 2025•
edited
Loading

@sobolevn@picnixz@skirpichev can you please review?

@skirpichevskirpichev added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 12, 2025
@mkaraev
Copy link
ContributorAuthor

mkaraev commentedMay 12, 2025•
edited
Loading

@skirpichev you added two labels about back-porting to python 3.13 and 3.14. Do I need to make similar changes to that branches too?

@skirpichev
Copy link
Contributor

you added two labels about back-porting to python 3.13 and 3.14. Do I need to make similar changes to that branches too?

No, I think the witch will do her job this time.

mkaraev reacted with thumbs up emoji

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

@sobolevnsobolevnenabled auto-merge (squash)May 12, 2025 09:06
@sobolevn
Copy link
Member

Congrats on your first CPython PR 🎉

mkaraev reacted with thumbs up emoji

@sobolevnsobolevndisabled auto-mergeMay 12, 2025 09:13
@sobolevnsobolevnenabled auto-merge (squash)May 12, 2025 09:14
@sobolevnsobolevn merged commit27ed645 intopython:mainMay 12, 2025
39 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsMay 12, 2025
@miss-islington-app
Copy link

Thanks@mkaraev for the PR, and@sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 12, 2025
(cherry picked from commit27ed645)Co-authored-by: mkaraev <maruf.karaev97@gmail.com>Co-authored-by: sobolevn <mail@sobolevn.me>
@miss-islington-app
Copy link

Sorry,@mkaraev and@sobolevn, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 27ed64575d34f04029ba1d353810f3db4f4f045b 3.13

@bedevere-app
Copy link

GH-133918 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 12, 2025
@sobolevn
Copy link
Member

@mkaraev can you please do a manual backport to 3.13? follow instructions in#133907 (comment)

@mkaraev
Copy link
ContributorAuthor

@sobolevn sure, will do

@mkaraev
Copy link
ContributorAuthor

@sobolevn I tried to cherry pick manually and got some strange error.
Opened issuepython/cherry-picker#159
Maybe I'm doing something wrong.

@bedevere-app
Copy link

GH-133922 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 12, 2025
sobolevn added a commit that referenced this pull requestMay 12, 2025
…3922)* [3.13]gh-133904: Fix `math.factorial` documentation (GH-133907)(cherry picked from commit27ed645)Co-authored-by: mkaraev <maruf.karaev97@gmail.com>Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull requestMay 12, 2025
…3918)gh-133904: Fix `math.factorial` documentation (GH-133907)(cherry picked from commit27ed645)Co-authored-by: mkaraev <maruf.karaev97@gmail.com>Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@skirpichevskirpichevskirpichev approved these changes

@sobolevnsobolevnsobolevn approved these changes

Assignees

@sobolevnsobolevn

Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mkaraev@skirpichev@sobolevn
[8]ページ先頭
©2009-2025 Movatter.jp