Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133893: asyncio.graph: Replace TextIO annotation with io.Writer#133894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 5 commits intopython:mainfromsrittau:print-graph
May 11, 2025

Conversation

srittau
Copy link
Contributor

@srittausrittau commentedMay 11, 2025•
edited by bedevere-appbot
Loading

Considering that this is a new module in 3.14, I think this should be backported.

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think that news entry should be added here, there's no user-visible change.

Other than that - LGTM! 👍

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

@sobolevnsobolevn merged commit1d3eace intopython:mainMay 11, 2025
44 checks passed
@miss-islington-app
Copy link

Thanks@srittau for the PR, and@sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 11, 2025
…ter (pythonGH-133894)(cherry picked from commit1d3eace)Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
@bedevere-app
Copy link

GH-133901 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 11, 2025
@sobolevn
Copy link
Member

@srittau@JelleZijlstra do know how we can type-check this file and several others inLib/asyncio/? It might be a good idea. Depending on how complex the setup will be.

@srittausrittau deleted the print-graph branchMay 11, 2025 15:17
@srittau
Copy link
ContributorAuthor

Type checking in the standard library has been a contentious issue, see for examplehttps://discuss.python.org/t/type-annotations-in-the-stdlib/21487/2

I personally think that all annotated code in the standard library should be type checked, but this is probably a PEP-level problem that will cause a lot of pushback.

sobolevn reacted with thumbs up emoji

@JelleZijlstra
Copy link
Member

There's also practical issues because type checkers assume standard library code is in typeshed.@ambv talked on the core.py podcast recently about how they achieved type checking for pyrepl with some symlink trick; but pyrepl might be a slightly easier case because it's private and not in typeshed.

sobolevn pushed a commit that referenced this pull requestMay 11, 2025
…iter (GH-133894) (#133901)gh-133893: asyncio.graph: Replace TextIO annotation with io.Writer (GH-133894)(cherry picked from commit1d3eace)Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
@sobolevn
Copy link
Member

I already sneaked intotomllib type-checking, see:#133118

It might be a reference for future work.

srittau reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@sobolevnsobolevnsobolevn approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@srittau@sobolevn@JelleZijlstra
[8]ページ先頭
©2009-2025 Movatter.jp