Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133604: remove deprecatedjava_ver function#133888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
malemburg merged 14 commits intopython:mainfrommakridenko:fix-issue-133604
May 16, 2025

Conversation

makridenko
Copy link
Contributor

@makridenkomakridenko commentedMay 11, 2025•
edited
Loading

@python-cla-bot
Copy link

python-cla-botbot commentedMay 11, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

platform
--------

* The deprecated :func:`!platform.java_ver` function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
*The deprecated:func:`!platform.java_ver` function.
*Removed the deprecated:func:`!platform.java_ver` function.

To save Benedikt copy-editing it later. (See line 133)

You can also link this pr. (See line 134 as an example)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@StanFromIreland thank you! done

@@ -31,6 +31,7 @@
#
# <see CVS and SVN checkin messages for history>
#
# 1.1.0 - removed deprecated java_ver()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not noteworthy enough IMO. These are rarely updated, but it is up to@malemburg in the end.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No need to add to that list anymore. The checkin messages provide enough history.

StanFromIreland reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You may want to change# <see CVS and SVN checkin messages for history> to# <see checkin messages for history>

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@malemburg thank you! done

Comment on lines 127 to 128
* Removed the deprecated :func:`!platform.java_ver` function.
(Contributed by Alexey Makridenko in :gh:`133888`.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
* Removed the deprecated:func:`!platform.java_ver` function.
(Contributed by Alexey Makridenko in:gh:`133888`.)
* Removed the:func:`!platform.java_ver` function,
which was deprecated since Python 3.13.
(Contributed by Alexey Makridenko in:gh:`133888`.)

The link should be the issue, not the PR.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thank you! fixed it

@@ -0,0 +1 @@
Remove deprecated function :func:`!platform.java_ver`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Removedeprecated function:func:`!platform.java_ver`.
Remove:func:`!platform.java_ver` which was deprecated since Python 3.13.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thank you! fixed it

@makridenkomakridenko requested a review frompicnixzMay 16, 2025 11:48
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry to give you contradictory comments :') I didn't read the previous reviews, my bad!

Copy link
Member

@malemburgmalemburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, though I haven't actually run the test suite with these changes, or built the docs.

Note: The PR branch needs to be rebased before it can be merged.

@malemburg
Copy link
Member

Hmm, apparently, Github changed its mind about the need to rebase.

@malemburg
Copy link
Member

@StanFromIreland Do want to review again ? Otherwise, I'll merge the PR soon.

@malemburgmalemburg merged commit7a4a6cf intopython:mainMay 16, 2025
39 checks passed
@malemburg
Copy link
Member

Thanks,@makridenko, for your work on this.

makridenko reacted with heart emoji

@StanFromIreland
Copy link
Contributor

Apologies I was unavailable.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@eendebakpteendebakpteendebakpt left review comments

@picnixzpicnixzpicnixz approved these changes

@malemburgmalemburgmalemburg approved these changes

@StanFromIrelandStanFromIrelandAwaiting requested review from StanFromIreland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@makridenko@malemburg@StanFromIreland@eendebakpt@picnixz
[8]ページ先頭
©2009-2025 Movatter.jp