NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

gh-133400: Fixed Ctrl+D (^D) behavior in :mod:`_pyrepl` module#133883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

deepwzh wants to merge1 commit intopython:main

base:main

Choose a base branch

fromdeepwzh:fix-issue-133400

Open

gh-133400: Fixed Ctrl+D (^D) behavior in :mod:`_pyrepl` module#133883

deepwzh wants to merge1 commit intopython:mainfromdeepwzh:fix-issue-133400

+46 −0

Conversation

Copy link

deepwzh commentedMay 11, 2025•
edited by bedevere-appbot
Loading

Fixed Ctrl+D (^D) behavior in :mod:_pyrepl module:

Now properly exits multiline mode when pressed in multiline section
Added test cases to verify the behavior in both multiline and single line modes

Issue:pyrepl: Unable to ^D exit in multiline section #133400

deepwzh requested review frompablogsal,lysnikolaou andambv ascode owners

May 11, 2025 09:47

bedevere-appbot mentioned this pull request

May 11, 2025

pyrepl: Unable to ^D exit in multiline section#133400

Open

bedevere-appbot added the awaiting review label

May 11, 2025

pythongh-133400: Fixed Ctrl+D (^D) behavior in :mod:_pyreplmodule

b0c288a

deepwzh force-pushed thefix-issue-133400 branch from16848f9 tob0c288aCompare

May 11, 2025 09:47

Copy link

Contributor

StanFromIreland commentedMay 11, 2025•
edited
Loading

This is not ideal:

>>>ifTrue:...File"<python-input-2>",line1ifTrue:^IndentationError:expectedanindentedblockafter'if'statementonline1>>>

Copy link

Author

deepwzh commentedMay 11, 2025

This is not ideal:

>>>ifTrue:...File"<python-input-2>",line1ifTrue:^IndentationError:expectedanindentedblockafter'if'statementonline1>>>

This fix is to correctly handle the issue of Ctrl+D to exit multi-line mode. What do you think the expected behavior should be?
@StanFromIreland

ZeroIntensity added topic-repl

Related to the interactive shell

needs backport to 3.13

bugs and security fixes

needs backport to 3.14bugs and security fixes labels

May 11, 2025

Copy link

Contributor

feoh commentedMay 19, 2025•
edited
Loading

@ambv FWIW I tested this PR on my Mac (main branch, latest, MacOS latest) and it works great. I tried throwing a bunch of other unclosed constructs (e.g. {, [, etc.) and none exhibited this error either.

Copy link

Contributor

feoh commentedMay 19, 2025

@StanFromIreland Are you suggesting that the error message in the if True: case could be more clear?

The fact that the user isn't supplying a valid indented block after the if True: is indeed a problem the language needs to flag, so I'm curious what specific wording you think might be more clear. Also it seems to me like this could be a separate Github issue. Do you agree?