Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133677: Fix tests when running in non-UTF-8 locale#133865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedMay 11, 2025•
edited by bedevere-appbot
Loading

@@ -791,21 +791,21 @@ def test_table_output_format(self):
class TestAsyncioToolsEdgeCases(unittest.TestCase):

def test_task_awaits_self(self):
"""A task directly awaits itself– should raise a cycle."""
"""A task directly awaits itself- should raise a cycle."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These are all unrelated.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is very related. Error happens when non-ASCII "–" is written to stdout with a non-UTF-8 encoding.

AA-Turner reacted with thumbs up emoji
@StanFromIreland
Copy link
Contributor

This is also against the wrong branch, main will be unaffected once#133712

@serhiy-storchakaserhiy-storchaka merged commit14305a8 intopython:mainMay 12, 2025
42 checks passed
@serhiy-storchakaserhiy-storchaka deleted the tests-non-utf8-locale branchMay 12, 2025 16:14
@serhiy-storchakaserhiy-storchaka added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 12, 2025
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 12, 2025
…-133865)(cherry picked from commit14305a8)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington-app
Copy link

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 14305a83d381ccdcae814abd9e2c28dda066720b 3.13

@bedevere-app
Copy link

GH-133938 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 12, 2025
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestMay 12, 2025
…ythonGH-133865)(cherry picked from commit14305a8)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-133939 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 12, 2025
@serhiy-storchakaserhiy-storchaka removed their assignmentMay 12, 2025
serhiy-storchaka added a commit that referenced this pull requestMay 12, 2025
…) (GH-133938)(cherry picked from commit14305a8)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@StanFromIreland
Copy link
Contributor

Relevant buildbot run for this PR:https://buildbot.python.org/#/builders/1678/builds/37 (Not linked by gh at the moment)

serhiy-storchaka added a commit that referenced this pull requestMay 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@AA-TurnerAA-TurnerAA-Turner approved these changes

@barneygalebarneygaleAwaiting requested review from barneygalebarneygale is a code owner

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@serhiy-storchaka@StanFromIreland@AA-Turner
[8]ページ先頭
©2009-2025 Movatter.jp