Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132983: Convert zstd __new__ methods to Argument Clinic#133860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 9 commits intopython:mainfromAA-Turner:zstd-ac-new
May 12, 2025

Conversation

AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commentedMay 11, 2025•
edited by bedevere-appbot
Loading

  • merge thetp_init functions intotp_new and convert the latter to AC. This also means we can remove theinitialised member from the object structs.
  • Change the signature ofZstdDict to make the content positional-only andis_raw kw-only.
  • Use Zstandard where appropriate to refer to the compression algorithm, instead of the reference implementation.

A

cc@Rogdham

@AA-TurnerAA-Turner added skip news needs backport to 3.14bugs and security fixes labelsMay 11, 2025
@AA-TurnerAA-Turner changed the titlegh-133856: Convert zstd __new__ methods to Argument Clinicgh-132983: Convert zstd __new__ methods to Argument ClinicMay 11, 2025
Copy link
Member

@emmatypingemmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A few suggestions but otherwise looks great!

@AA-TurnerAA-Turnerenabled auto-merge (squash)May 12, 2025 08:24
@AA-TurnerAA-Turner merged commitd29ddbd intopython:mainMay 12, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks@AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@AA-TurnerAA-Turner deleted the zstd-ac-new branchMay 12, 2025 08:51
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 12, 2025
…ythonGH-133860)(cherry picked from commitd29ddbd)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

GH-133915 is a backport of this pull request to the3.14 branch.

@encukou
Copy link
Member

Since this was merged, buildbots started showing reference leaks, e.g.here.

@encukou
Copy link
Member

See#133962 for a fix-up.

AA-Turner added a commit that referenced this pull requestMay 20, 2025
…GH-133860) (#133915)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@emmatypingemmatypingemmatyping approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@AA-Turner@encukou@emmatyping
[8]ページ先頭
©2009-2025 Movatter.jp