Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove trailing whitespace from python.gram#133858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 2 commits intopython:mainfromrffontenelle:patch-8
May 14, 2025

Conversation

rffontenelle
Copy link
Contributor

The intention is to solve "trailing whitespace" warning by sphinx-lint when running against translation files. That's related but not a duplicated of#133175.

Running sphinx-lint againstthis state of reference/grammar.po from pt_BR, these trailing whitespaces caused:

$ sphinx-lint reference/grammar.po reference/grammar.po:162: trailing whitespace (trailing-whitespace)reference/grammar.po:163: trailing whitespace (trailing-whitespace)reference/grammar.po:167: trailing whitespace (trailing-whitespace)reference/grammar.po:515: trailing whitespace (trailing-whitespace)reference/grammar.po:516: trailing whitespace (trailing-whitespace)reference/grammar.po:517: trailing whitespace (trailing-whitespace)reference/grammar.po:529: trailing whitespace (trailing-whitespace)reference/grammar.po:530: trailing whitespace (trailing-whitespace)reference/grammar.po:531: trailing whitespace (trailing-whitespace)reference/grammar.po:1043: trailing whitespace (trailing-whitespace)reference/grammar.po:1045: trailing whitespace (trailing-whitespace)reference/grammar.po:1046: trailing whitespace (trailing-whitespace)reference/grammar.po:1047: trailing whitespace (trailing-whitespace)reference/grammar.po:1449: trailing whitespace (trailing-whitespace)reference/grammar.po:1453: trailing whitespace (trailing-whitespace)

m-aciek reacted with thumbs up emoji
@AA-Turner
Copy link
Member

An alternative is just to silence the downstream warnings, but I've pushed a commit here to ensure no future whitespace regressions if we do merge this one.

A

rffontenelle, m-aciek, hugovk, and SouravKumarBarman reacted with thumbs up emojim-aciek reacted with heart emoji

@rffontenelle
Copy link
ContributorAuthor

@AA-Turner Do you think there is a way to make gettext builder not extract such string?

@AA-Turner
Copy link
Member

Can you elaborate?

@rffontenelle
Copy link
ContributorAuthor

Some kind of flag that could be added to the reST file to make gettext builder understand that the text should not be extracted into a POT file.

@hugovkhugovk added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 11, 2025
@StanFromIreland
Copy link
Member

Excluding it entirely:#133868

@rffontenelle
Copy link
ContributorAuthor

FYI: rebased to main

@hugovkhugovk merged commit6df3976 intopython:mainMay 14, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks@rffontenelle for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 14, 2025
(cherry picked from commit6df3976)Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
@miss-islington-app
Copy link

Sorry,@rffontenelle and@hugovk, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 6df39765e652ba06267f8e7abae431c37194a23e 3.13

@bedevere-app
Copy link

GH-133990 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 14, 2025
hugovk pushed a commit to hugovk/cpython that referenced this pull requestMay 14, 2025
Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>(cherry picked from commit6df3976)
@bedevere-app
Copy link

GH-133991 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 14, 2025
hugovk pushed a commit that referenced this pull requestMay 14, 2025
Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
hugovk added a commit that referenced this pull requestMay 14, 2025
Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
@rffontenellerffontenelle deleted the patch-8 branchMay 14, 2025 12:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

@m-aciekm-aciekm-aciek approved these changes

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygoodAlexWaygood is a code owner

Assignees

@hugovkhugovk

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@rffontenelle@AA-Turner@StanFromIreland@hugovk@m-aciek
[8]ページ先頭
©2009-2025 Movatter.jp