Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-132983: Remove EndlessZstdDecompressor remains#133856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-132983: Remove EndlessZstdDecompressor remains#133856
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
878e0fb
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@Rogdham for the PR, and@AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…nGH-133856)(cherry picked from commit878e0fb)Co-authored-by: Rogdham <3994389+Rogdham@users.noreply.github.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
GH-133859 is a backport of this pull request to the3.14 branch. |
…33856) (#133859)gh-132983: Remove leftovers from EndlessZstdDecompressor (GH-133856)(cherry picked from commit878e0fb)Co-authored-by: Rogdham <3994389+Rogdham@users.noreply.github.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
cc@emmatyping@AA-Turner (can't request review)
In
pyzstd
there was anEndlessZstdDecompressor
class implemented in the C module. Some remains of the code were left, this PR aims to remove them.In the comments,
<D>
refers toZstdDecompressor
whereas<E>
refers toEndlessZstdDecompressor
. I cleaned that up as well.There was
_unused_char_for_align
in theZstdDecompressor
struct. My understanding is that it was placed only for optimization indecompressor_reset_session
when setting several attributes to 0 at once. I removed it here, but if needed I can re-add it (twice to compensate the removal ofat_frame_edge
).