Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-132983: Remove EndlessZstdDecompressor remains#133856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Rogdham
Copy link
Contributor

@RogdhamRogdham commentedMay 10, 2025
edited by bedevere-appbot
Loading

cc@emmatyping@AA-Turner (can't request review)

Inpyzstd there was anEndlessZstdDecompressor class implemented in the C module. Some remains of the code were left, this PR aims to remove them.

In the comments,<D> refers toZstdDecompressor whereas<E> refers toEndlessZstdDecompressor. I cleaned that up as well.

There was_unused_char_for_align in theZstdDecompressor struct. My understanding is that it was placed only for optimization indecompressor_reset_session when setting several attributes to 0 at once. I removed it here, but if needed I can re-add it (twice to compensate the removal ofat_frame_edge).

@AA-TurnerAA-Turnerenabled auto-merge (squash)May 11, 2025 01:38
@AA-TurnerAA-Turner merged commit878e0fb intopython:mainMay 11, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks@Rogdham for the PR, and@AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 11, 2025
…nGH-133856)(cherry picked from commit878e0fb)Co-authored-by: Rogdham <3994389+Rogdham@users.noreply.github.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link

GH-133859 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 11, 2025
AA-Turner added a commit that referenced this pull requestMay 11, 2025
…33856) (#133859)gh-132983: Remove leftovers from EndlessZstdDecompressor (GH-133856)(cherry picked from commit878e0fb)Co-authored-by: Rogdham <3994389+Rogdham@users.noreply.github.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@RogdhamRogdham deleted the remove-endlessdzstddecompressor-remains branchMay 11, 2025 07:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAA-Turner approved these changes

@ZeroIntensityZeroIntensityZeroIntensity left review comments

@emmatypingemmatypingAwaiting requested review from emmatyping

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Rogdham@AA-Turner@ZeroIntensity

[8]ページ先頭

©2009-2025 Movatter.jp