NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-133850: Improved SyntaxError message for missing commas#133851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

StanFromIreland wants to merge2 commits intopython:main

base:main

Choose a base branch

fromStanFromIreland:error-msg

Open

gh-133850: Improved SyntaxError message for missing commas#133851

StanFromIreland wants to merge2 commits intopython:mainfromStanFromIreland:error-msg

+75 −0

Conversation

Copy link

Contributor

StanFromIreland commentedMay 10, 2025•
edited
Loading

Before:

>>>deffunc1(uhohnocomma):passFile"<python-input-0>",line1deffunc1(uhohnocomma):pass^^^^^^^SyntaxError:invalidsyntax

Now:

>>>deffunc2(uhohnocomma):passFile"<python-input-0>",line1deffunc2(uhohnocomma):pass^^^^^^^^^^^^SyntaxError:expectedcommabetweenparameters

Issue:ImproveSyntaxError message for missing commas #133850

Commit

e3d5252

StanFromIreland requested review frompablogsal andlysnikolaou ascode owners

May 10, 2025 19:38

bedevere-appbot mentioned this pull request

May 10, 2025

ImproveSyntaxError message for missing commas#133850

Open

bedevere-appbot added the awaiting review label

May 10, 2025

python locked and limited conversation to collaborators

May 10, 2025

This comment was marked as outdated.

python unlocked this conversation

May 10, 2025

Copy link

ContributorAuthor

StanFromIreland commentedMay 11, 2025

@sobolevn Maybe you would be interested in reviewing?

terryjreedy previously requested changes

May 14, 2025

View reviewed changes

Copy link

Member

terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Grammar change works, but I cannot verify that is 'most correct' possible.

Grammar/python.gramShow resolvedHide resolved

bedevere-appbot added awaiting changes and removed awaiting review labels

May 14, 2025

Copy link

bedevere-appbot commentedMay 14, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!