Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Add classmethod to setUpClass in test_pdb#133840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4f2f780 intopython:main 50 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 10, 2025
(cherry picked from commit4f2f780)Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 10, 2025
(cherry picked from commit4f2f780)Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
GH-133846 is a backport of this pull request to the3.14 branch. |
GH-133847 is a backport of this pull request to the3.13 branch. |
gaogaotiantian added a commit that referenced this pull requestMay 10, 2025
gaogaotiantian added a commit that referenced this pull requestMay 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a mistake in
PdbTestReadlinewheresetUpClasswas not decorated withclassmethodand it did not have any argument - which made it magically work in the wrong way. We'll just fix this. This is a test-only fix and it's trivial so I'll skip everything. Backporting is safe - maybe not necessary, but again it's test only and it's obviously more correct.