Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-133829: Update zipimport example to not mention Python 2.3#133835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again. |
Uh oh!
There was an error while loading.Please reload this page.
…and ``import example``
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
@AA-Turner, what do you think?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
@AA-Turner Please give final review |
Someone please merge this since@AA-Turner isnt reviewing any time soon |
Let's be patient! Adam will review when he gets a chance to do so. People are busy, and complaining doesn't get it landed any faster (though sometimes I wish it did 😉) |
Sorry, bad mood that day :) finals …On Sun, May 18, 2025 at 10:28 AM Peter Bierma ***@***.***> wrote: *ZeroIntensity* left a comment (python/cpython#133835) <#133835 (comment)> Let's be patient! Adam will review when he gets a chance to do so. People are busy, and complaining doesn't get it landed any faster (though sometimes I wish it did 😉) — Reply to this email directly, view it on GitHub <#133835 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BNITW5YDDF5JIKSGGUQNGPD27CKJZAVCNFSM6AAAAAB425AMWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBZGAZDCOJQGY> . You are receiving this because you authored the thread.Message ID: ***@***.***> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM with one suggestion
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@AA-Turner Please give the final review when you get enough time next. Thank you! |
Again, be patient. Spam pinging someone does not help their motivation to review. The devguiderecommends waiting at least a month before tagging anyone. |
I know, I just wanted to leave a nicer message than my last one, and I forgot about the edit button for a second |
Uh oh!
There was an error while loading.Please reload this page.
#133829
Updates this zipimport example:https://docs.python.org/3.14/library/zipimport.html#examples which uses Python 2.3 to use 3.x and pip.pyz as the new example
This willclose#133829
Ready for review
📚 Documentation preview 📚:https://cpython-previews--133835.org.readthedocs.build/en/133835/library/zipimport.html#examples