Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133829: Update zipimport example to not be from Python 2#133835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sharktide wants to merge12 commits intopython:main
base:main
Choose a base branch
Loading
fromsharktide:patch-133829

Conversation

sharktide
Copy link
Contributor

@sharktidesharktide commentedMay 10, 2025•
edited by ZeroIntensity
Loading

#133829

Updates this zipimport example:https://docs.python.org/3.14/library/zipimport.html#examples which uses Python 2.3 to use 3.x and pip.pyz as the new example

This willclose#133829

Ready for review

📚 Documentation preview 📚:https://cpython-previews--133835.org.readthedocs.build/en/133835/library/zipimport.html#examples

@tomasr8tomasr8 changed the titlegh-133829 Update zipimport example to use pip.pyzgh-133829: Update zipimport example to use pip.pyzMay 10, 2025
@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sharktide
Copy link
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-appbedevere-appbot requested a review fromAA-TurnerMay 10, 2025 22:53
@sharktide
Copy link
ContributorAuthor

@AA-Turner i completely removed the bash part to make a MWE

@AA-Turner
Copy link
Member

I'd suggest using Ryan's example on the issue, currently there's no provenance for pip.pyz.

@sharktide
Copy link
ContributorAuthor

sharktide commentedMay 10, 2025 via email

Will do soon
…
On Sat, May 10, 2025 at 19:13 Adam Turner ***@***.***> wrote: *AA-Turner* left a comment (python/cpython#133835) <#133835 (comment)> I'd suggest using Ryan's example on the issue, currently there's no provenance for pip.pyz. — Reply to this email directly, view it on GitHub <#133835 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BNITW5YAIEXLM2CV4MCOHB3252BYPAVCNFSM6AAAAAB425AMWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNRZGIYTCMRRHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

@sharktidesharktide requested a review fromsobolevnMay 11, 2025 13:05
@sharktidesharktide requested a review fromsobolevnMay 11, 2025 16:32
@sharktidesharktide requested a review fromsobolevnMay 11, 2025 16:50
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@AA-Turner, what do you think?

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@sharktide

This comment was marked as resolved.

@sharktide
Copy link
ContributorAuthor

@AA-Turner Please give final review

@sharktidesharktide changed the titlegh-133829: Update zipimport example to use pip.pyzgh-133829: Update zipimport example to not be from Python 2May 17, 2025
@sharktide
Copy link
ContributorAuthor

Someone please merge this since@AA-Turner isnt reviewing any time soon

@ZeroIntensity
Copy link
Member

Let's be patient! Adam will review when he gets a chance to do so. People are busy, and complaining doesn't get it landed any faster (though sometimes I wish it did 😉)

@sharktide
Copy link
ContributorAuthor

sharktide commentedMay 18, 2025 via email

Sorry, bad mood that day :) finals
…
On Sun, May 18, 2025 at 10:28 AM Peter Bierma ***@***.***> wrote: *ZeroIntensity* left a comment (python/cpython#133835) <#133835 (comment)> Let's be patient! Adam will review when he gets a chance to do so. People are busy, and complaining doesn't get it landed any faster (though sometimes I wish it did 😉) — Reply to this email directly, view it on GitHub <#133835 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BNITW5YDDF5JIKSGGUQNGPD27CKJZAVCNFSM6AAAAAB425AMWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBZGAZDCOJQGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>
ZeroIntensity reacted with heart emoji

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM with one suggestion

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@adorilsonadorilsonadorilson left review comments

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@sobolevnsobolevnsobolevn approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-Turner

Assignees
No one assigned
Labels
awaiting mergedocsDocumentation in the Doc dirskip news
Projects
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update zipimport example (uses Python 2.3)
6 participants
@sharktide@AA-Turner@ZeroIntensity@adorilson@sobolevn@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp