Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133439: simplify how errors are reported by sqlite3 CLI#133807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
StanFromIreland wants to merge4 commits intopython:main
base:main
Choose a base branch
Loading
fromStanFromIreland:sqlite3-fixup

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIrelandStanFromIreland commentedMay 10, 2025•
edited by bedevere-appbot
Loading

  • Useprint for file consistency
  • Actually test for the full improved error message
  • Correct error message, messages do not have the '.'

Request:@erlend-aasland

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think this PR is needed anymore, except maybe for theassertIn

@StanFromIreland
Copy link
ContributorAuthor

Should the error message not be consistent with all other cpython error messages?

I think it is still better to useprint for clarity (we don't have to look it up) and consistency, all other writing in the file is done so.

@picnixz
Copy link
Member

picnixz commentedMay 10, 2025•
edited
Loading

I think it is still better to use print for clarity (we don't have to look it up) and consistency, all other writing in the file is done so.

I guess so. I actually expectedInteractiveConsole to have awrite_stderr and awrite_stdout but there's none, so maybe only usingprint makes sense. WDYT@erlend-aasland?

@picnixzpicnixz changed the titlegh-133439: Fixup sqlite3 changes in 133440gh-133439: simplify how errors are reported by sqlite3 CLIMay 10, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixzpicnixz added the needs backport to 3.14bugs and security fixes labelMay 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@StanFromIreland@picnixz
[8]ページ先頭
©2009-2025 Movatter.jp