Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133403: CheckTools/build/deepfreeze.py with mypy#133802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 2 commits intopython:mainfromsobolevn:issue-133403-3
May 15, 2025

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedMay 10, 2025•
edited by bedevere-appbot
Loading

@@ -402,7 +417,7 @@ def generate(self, name: str, obj: object) -> str:
# print(f"Cache hit {key!r:.40}: {self.cache[key]!r:.40}")
return self.cache[key]
self.misses += 1
if isinstance(obj,(types.CodeType, umarshal.Code)) :
if isinstance(obj, types.CodeType) :
Copy link
MemberAuthor

@sobolevnsobolevnMay 10, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hereumarshal.Code won't work, becausegenerate_code requires a lot more attrs thanumarshal.Code has

@sobolevnsobolevn merged commit7eaa097 intopython:mainMay 15, 2025
50 checks passed
@miss-islington-app
Copy link

Thanks@sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 15, 2025
…H-133802)(cherry picked from commit7eaa097)Co-authored-by: sobolevn <mail@sobolevn.me>
@miss-islington-app
Copy link

Sorry,@sobolevn, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 7eaa09739059aaac4812395f8d6bb586af8eadcc 3.13

@bedevere-app
Copy link

GH-134038 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 15, 2025
sobolevn added a commit to sobolevn/cpython that referenced this pull requestMay 15, 2025
…ythonGH-133802)(cherry picked from commit7eaa097)Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

GH-134040 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 15, 2025
sobolevn added a commit that referenced this pull requestMay 15, 2025
) (#134038)gh-133403: Check `Tools/build/deepfreeze.py` with mypy (GH-133802)(cherry picked from commit7eaa097)Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull requestMay 15, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygoodAlexWaygood is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees

@sobolevnsobolevn

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sobolevn@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp