Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-132983: Reduce the size of_zstdmodule.h
#133793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
_zstdmodule.h
_zstdmodule.h
Nit note about PR titles, the convention is lowercase gh-NNN for issues, and uppercase GH-NNN for PRs:
https://devguide.python.org/getting-started/pull-request-lifecycle/#submitting
https://devguide.python.org/core-developers/committing/#backporting-changes-to-an-older-version |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's fun that the diff for reducing the size is +165/-164.
1a548c0
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
(cherry picked from commit1a548c0)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
GH-133854 is a backport of this pull request to the3.14 branch. |
Uh oh!
There was an error while loading.Please reload this page.
We should try and reduce the content in the header file, as it is exposed to anything that includes it.
mt_continue_should_break()
moves intocompressor.c
decompress_type
enum moves intodecompressor.c
#pragma once
(not used for any other modules or non-vendored code) with guard definesz{std,dict}.h
zstddict.h
header file to contain the definition of theZstdDict
structZstdCompressor
struct tocompressor.c
(likewise for decompressor)PyModuleDef _zstdmodule
staticA