Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-132983: Reduce the size of_zstdmodule.h#133793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 10 commits intopython:mainfromAA-Turner:zstd-headers
May 10, 2025

Conversation

AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commentedMay 10, 2025
edited by bedevere-appbot
Loading

We should try and reduce the content in the header file, as it is exposed to anything that includes it.

  • mt_continue_should_break() moves intocompressor.c
  • Thedecompress_type enum moves intodecompressor.c
  • Replace#pragma once (not used for any other modules or non-vendored code) with guard defines
  • Use angle-bracket includes forz{std,dict}.h
  • Add azstddict.h header file to contain the definition of theZstdDict struct
  • Move theZstdCompressor struct tocompressor.c (likewise for decompressor)
  • MakePyModuleDef _zstdmodule static

A

@hugovkhugovk changed the titleGH-132983: Reduce the size of_zstdmodule.hgh-132983: Reduce the size of_zstdmodule.hMay 10, 2025
@hugovk
Copy link
Member

Nit note about PR titles, the convention is lowercase gh-NNN for issues, and uppercase GH-NNN for PRs:

please make sure to reference the issue number usinggh-NNNNN: prefix in the pull request title

https://devguide.python.org/getting-started/pull-request-lifecycle/#submitting

[3.9] gh-12345: Fix the Spam Module (GH-NNNN)

Heregh-12345 is the GitHubissue number, andGH-NNNN is the number of the originalpull request.

https://devguide.python.org/core-developers/committing/#backporting-changes-to-an-older-version

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's fun that the diff for reducing the size is +165/-164.

AA-Turner and emmatyping reacted with laugh emoji
@AA-TurnerAA-Turner merged commit1a548c0 intopython:mainMay 10, 2025
42 checks passed
@miss-islington-app
Copy link

Thanks@AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 10, 2025
(cherry picked from commit1a548c0)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

GH-133854 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 10, 2025
@AA-TurnerAA-Turner deleted the zstd-headers branchMay 10, 2025 21:48
AA-Turner added a commit that referenced this pull requestMay 10, 2025
…133854)gh-132983: Reduce the size of ``_zstdmodule.h`` (GH-133793)(cherry picked from commit1a548c0)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@emmatypingemmatypingemmatyping approved these changes

@picnixzpicnixzpicnixz approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@AA-Turner@hugovk@emmatyping@picnixz

[8]ページ先頭

©2009-2025 Movatter.jp