Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132983: Fix small issues with zstd support in zipfile#133723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

pR0Ps
Copy link
Contributor

@pR0PspR0Ps commentedMay 9, 2025•
edited by bedevere-appbot
Loading

Some small tweaks to the zipfile zstd support added in#133365

  • AddZIP_ZSTANDARD constant to the module's__all__
  • Add zstd notes to theZipFile's docstring.
  • Add a missing check formin_level in_write_end_record
  • Pass through the specifiedcompresslevel into theZstdCompressor and document it.

Note: I didn't create an issue because this all seems fairly trivial, but I can if needed.

CC:@emmatyping@gpshead

Copy link
Member

@emmatypingemmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, these changes look good! I had a few minor suggestions. I think we should be careful how we document the accepted values for zstd's compression level. I don't think we can or should hardcode the values, but I also think giving a pointer to where the current values can be found would be useful.

@emmatypingemmatyping changed the titleFix small issues with zstd support in zipfileGH-132983: Fix small issues with zstd support in zipfileMay 9, 2025
@AA-TurnerAA-Turner added the needs backport to 3.14bugs and security fixes labelMay 9, 2025
Co-authored-by: Emma Smith <emma@emmatyping.dev>
@pR0Ps
Copy link
ContributorAuthor

All requested changes applied. I see a test failed, but as far as I can tell it's not related to the changes in this PR.

@hugovkhugovk changed the titleGH-132983: Fix small issues with zstd support in zipfilegh-132983: Fix small issues with zstd support in zipfileMay 10, 2025
@AA-TurnerAA-Turner merged commit35f47d0 intopython:mainMay 13, 2025
42 checks passed
@miss-islington-app
Copy link

Thanks@pR0Ps for the PR, and@AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 13, 2025
…nGH-133723)(cherry picked from commit35f47d0)Co-authored-by: Carey Metcalfe <carey@cmetcalfe.ca>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Emma Smith <emma@emmatyping.dev>
@bedevere-app
Copy link

GH-133974 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 13, 2025
AA-Turner added a commit that referenced this pull requestMay 13, 2025
…33723) (#133974)gh-132983: Fix small issues with zstd support in zipfile (GH-133723)(cherry picked from commit35f47d0)Co-authored-by: Carey Metcalfe <carey@cmetcalfe.ca>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Emma Smith <emma@emmatyping.dev>
@pR0PspR0Ps deleted the feature/zipfile-zstd-compresslevel branchMay 13, 2025 22:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAA-Turner approved these changes

@emmatypingemmatypingemmatyping approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@pR0Ps@AA-Turner@emmatyping
[8]ページ先頭
©2009-2025 Movatter.jp